Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resource fails to show when title is numeric #3208

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

Paul-Bob
Copy link
Contributor

@Paul-Bob Paul-Bob commented Sep 3, 2024

Description

Fixes #3201

Enforce String type on record_title method

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@Paul-Bob Paul-Bob self-assigned this Sep 3, 2024
@github-actions github-actions bot added the Fix label Sep 3, 2024
Copy link

codeclimate bot commented Sep 3, 2024

Code Climate has analyzed commit b18f1c6 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Collaborator

@adrianthedev adrianthedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not do nested if's

def record_title
  fetch_record_title.to_s
end

private

def fetch_record_title
  ce avem acum
end

@adrianthedev adrianthedev merged commit cd8d0dc into main Sep 3, 2024
22 checks passed
@adrianthedev adrianthedev deleted the fix/resource_fails_to_show_when_title_is_numeric branch September 3, 2024 10:45
Copy link
Contributor

github-actions bot commented Sep 3, 2024

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resource fails to show when self.title is numeric
2 participants