Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Test Sidebar #3108

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Chore: Test Sidebar #3108

merged 2 commits into from
Aug 8, 2024

Conversation

binarygit
Copy link
Contributor

@binarygit binarygit commented Aug 8, 2024

Description

Write tests for sidebar.

Fixes # (issue)

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Screenshots & recording

Manual review steps

  1. Step 1
  2. Step 2

Manual reviewer: please leave a comment with output from the test if that's the case.

Copy link

codeclimate bot commented Aug 8, 2024

Code Climate has analyzed commit 883567d and detected 0 issues on this pull request.

View more on Code Climate.

spec/system/sidebar_spec.rb Outdated Show resolved Hide resolved
spec/system/sidebar_spec.rb Outdated Show resolved Hide resolved
spec/system/sidebar_spec.rb Show resolved Hide resolved
spec/system/sidebar_spec.rb Show resolved Hide resolved
spec/system/sidebar_spec.rb Outdated Show resolved Hide resolved
spec/system/sidebar_spec.rb Outdated Show resolved Hide resolved
spec/system/sidebar_spec.rb Outdated Show resolved Hide resolved
spec/system/sidebar_spec.rb Outdated Show resolved Hide resolved
spec/system/sidebar_spec.rb Outdated Show resolved Hide resolved
spec/system/sidebar_spec.rb Outdated Show resolved Hide resolved
@binarygit binarygit requested a review from Paul-Bob August 8, 2024 10:43
Copy link
Contributor

@Paul-Bob Paul-Bob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM =)

@Paul-Bob Paul-Bob added the Chore label Aug 8, 2024
@Paul-Bob Paul-Bob merged commit e03e65d into main Aug 8, 2024
21 of 22 checks passed
@Paul-Bob Paul-Bob deleted the test-sidebar branch August 8, 2024 12:12
Copy link
Contributor

github-actions bot commented Aug 8, 2024

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants