Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: informative development error when search misconfigured #3098

Merged
merged 5 commits into from
Aug 9, 2024

Conversation

Paul-Bob
Copy link
Contributor

@Paul-Bob Paul-Bob commented Aug 6, 2024

Description

Fixes #3091

Related PR: https://github.com/avo-hq/avo-pro/pull/85

Raises an informative error (is displayed only on development) whenever a field has searchable: true but the target resource doesn't have the search configured.

search_error.mp4

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Copy link

codeclimate bot commented Aug 6, 2024

Code Climate has analyzed commit cbb2347 and detected 0 issues on this pull request.

View more on Code Climate.

@Paul-Bob Paul-Bob requested a review from adrianthedev August 6, 2024 13:06
@Paul-Bob Paul-Bob self-assigned this Aug 6, 2024
Copy link
Collaborator

@adrianthedev adrianthedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see if we can show a link in 5-10 minutes.

@Paul-Bob Paul-Bob merged commit b0cf834 into main Aug 9, 2024
22 checks passed
@Paul-Bob Paul-Bob deleted the feature/informative_error_when_resource_miss_search branch August 9, 2024 08:10
Copy link
Contributor

github-actions bot commented Aug 9, 2024

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Raise information error for undefined search query in development
2 participants