Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: trix and action text improvements #2958

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

adrianthedev
Copy link
Collaborator

Description

Fixes #2714

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Screenshots & recording

CleanShot 2024-07-08 at 21 43 38

@github-actions github-actions bot added the Fix label Jul 8, 2024
Copy link

codeclimate bot commented Jul 8, 2024

Code Climate has analyzed commit 6fcd325 and detected 0 issues on this pull request.

View more on Code Climate.

@adrianthedev
Copy link
Collaborator Author

@sedubois this PR fixes the caption issue.

I tried to replicate the hr issue you posted but it seems to be a Trix issue, not an Avo issue.
I created a reproduction area in the trix demo app under /posts.

You'll see that it does not save the hr either.
Please clone that repo and try it too.

CleanShot.2024-07-08.at.21.53.10.mp4

I'll merge this as is and if you find out anything about hr let's keep the conversation open.

@adrianthedev adrianthedev merged commit 9e339e3 into main Jul 8, 2024
21 of 22 checks passed
@adrianthedev adrianthedev deleted the fix/trix-action-text-broken branch July 8, 2024 19:52
Copy link
Contributor

github-actions bot commented Jul 8, 2024

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

@sedubois
Copy link
Contributor

Thank you so much @adrianthedev for fixing captions 👍
The hr issue is less blocking, will have a look if I find bandwidth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No documentation/demo/testing for Action Text has_rich_text
2 participants