Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: drop httparty dependency #2942

Merged
merged 2 commits into from
Jul 8, 2024
Merged

chore: drop httparty dependency #2942

merged 2 commits into from
Jul 8, 2024

Conversation

Paul-Bob
Copy link
Contributor

@Paul-Bob Paul-Bob commented Jul 4, 2024

Description

Fixes #2899

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@Paul-Bob Paul-Bob added dependencies Pull requests that update a dependency file Chore labels Jul 4, 2024
@Paul-Bob Paul-Bob self-assigned this Jul 4, 2024
@codeclimate CodeClimate
Copy link

codeclimate bot commented Jul 4, 2024 •
edited
Loading

Code Climate has analyzed commit 6db8017 and detected 0 issues on this pull request.

View more on Code Climate.

github-actions[bot]
github-actions bot reviewed Jul 4, 2024
View reviewed changes
lib/avo/licensing/request.rb Show resolved Hide resolved
lib/avo/licensing/request.rb Show resolved Hide resolved
adrianthedev
adrianthedev approved these changes Jul 4, 2024
View reviewed changes
Copy link
Collaborator

@adrianthedev adrianthedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Have you by any chance tested some of those exceptions by hand to see if they will be caught properly?

@Paul-Bob
Copy link
Contributor Author

Paul-Bob commented Jul 5, 2024

Tested SocketError, Errno::ECONNREFUSED, and Net::ReadTimeout

@Paul-Bob
Copy link
Contributor Author

Paul-Bob commented Jul 5, 2024

TODO: test OpenSSL::SSL::SSLError

@Paul-Bob Paul-Bob merged commit 0287524 into main Jul 8, 2024
19 of 21 checks passed
@Paul-Bob Paul-Bob deleted the chore/drop_httparty_dependency branch July 8, 2024 07:32
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 8, 2024

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@adrianthedev adrianthedev adrianthedev approved these changes

Assignees

@Paul-Bob Paul-Bob

Labels
Chore dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Httparty in favor of native ruby solution
2 participants
@Paul-Bob @adrianthedev