Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: extra map markers #2941

Merged
merged 5 commits into from
Jul 8, 2024
Merged

feature: extra map markers #2941

merged 5 commits into from
Jul 8, 2024

Conversation

Paul-Bob
Copy link
Contributor

@Paul-Bob Paul-Bob commented Jul 4, 2024

Description

This PR enables the ability to add custom markers to a map view.

self.map_view = {
  # ...
  extra_markers: -> do
    [
      {
        latitude: 37.780411,
        longitude: -25.497047,
        label: "Açores",
        tooltip: "São Miguel",
        color: "#0F0"
      }
    ]
  end,
  # ...
}

image

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@Paul-Bob Paul-Bob self-assigned this Jul 4, 2024
Copy link

codeclimate bot commented Jul 4, 2024

Code Climate has analyzed commit d52e96e and detected 0 issues on this pull request.

View more on Code Climate.

@Paul-Bob
Copy link
Contributor Author

Paul-Bob commented Jul 5, 2024

Rename custom_markers to extra_markers

@Paul-Bob Paul-Bob changed the title feature: custom map markers feature: extra map markers Jul 8, 2024
@Paul-Bob Paul-Bob merged commit cf6bc54 into main Jul 8, 2024
20 of 21 checks passed
@Paul-Bob Paul-Bob deleted the feature/custom_map_markers branch July 8, 2024 07:28
Copy link
Contributor

github-actions bot commented Jul 8, 2024

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant