Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent uuid collisions #1201

Closed
1t5j0y opened this issue Nov 24, 2023 · 2 comments
Closed

Prevent uuid collisions #1201

1t5j0y opened this issue Nov 24, 2023 · 2 comments
Assignees
@1t5j0y

Comments

@1t5j0y
Copy link
Contributor

1t5j0y commented Nov 24, 2023 •
edited by mahalakshme
Loading

Use a library like https://github.com/uuidjs/uuid

Acceptance criteria:

  • Replace manual UUID generation with a more robust library like above to prevent UUID collisions
  • Also identify how and why recently the no of UUID collisions have increased.
@1t5j0y 1t5j0y converted this from a draft issue Nov 24, 2023
This was referenced Nov 24, 2023
Closed
Closed
@mahalakshme mahalakshme moved this from New Issues to Ready in Avni Product Nov 27, 2023
@1t5j0y 1t5j0y moved this from Ready to In Progress in Avni Product Nov 28, 2023
@1t5j0y 1t5j0y self-assigned this Nov 28, 2023
1t5j0y added a commit that referenced this issue Nov 28, 2023
@1t5j0y
#1201 | Use crypto.randomUUID to generate random v4 uuids
9aac1b8
1t5j0y added a commit that referenced this issue Nov 28, 2023
@1t5j0y
Revert "#1201 | Use crypto.randomUUID to generate random v4 uuids"
a578af1 
This reverts commit 9aac1b8.
1t5j0y added a commit to avniproject/avni-models that referenced this issue Nov 28, 2023
@1t5j0y
avniproject/avni-client#1201 | Use uuid package to generate v4 UUIDs
2b2e8c6
1t5j0y added a commit that referenced this issue Nov 28, 2023
@1t5j0y
#1201 | Use 'uuid' package to generate random UUIDs
5dd5778
@mahalakshme
Copy link
Contributor

facebook/hermes#1169 - possible cause of issue - just added to keep track

@1t5j0y
Copy link
Contributor Author

1t5j0y commented Nov 28, 2023

Likely root cause - facebook/hermes#1169
Used 'uuid' library in both models and client.

@1t5j0y 1t5j0y moved this from In Progress to Code Review Ready in Avni Product Nov 28, 2023
@mahalakshme mahalakshme moved this from Code Review Ready to QA Ready in Avni Product Nov 28, 2023
@AchalaBelokar AchalaBelokar moved this from QA Ready to In QA in Avni Product Nov 28, 2023
@AchalaBelokar AchalaBelokar moved this from In QA to Done in Avni Product Nov 30, 2023
1t5j0y added a commit to avniproject/avni-models that referenced this issue Nov 30, 2023
@1t5j0y
avniproject/avni-client#1201 | Use uuid package to generate v4 UUIDs
13416cb
@himeshr himeshr mentioned this issue Jul 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@1t5j0y 1t5j0y

Labels
None yet
Projects
Avni Product
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vinayvenu @mahalakshme @1t5j0y