Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting reviewer within the pr create step #511

Open
drone-ah opened this issue Jan 9, 2025 · 1 comment
Open

Setting reviewer within the pr create step #511

drone-ah opened this issue Jan 9, 2025 · 1 comment

Comments

@drone-ah
Copy link

drone-ah commented Jan 9, 2025

Hi,

I find aviator to be a great product, particularly in managing stacked pr's. Thank you for the work that has gone into it.

I know that av stack create has a flag --reviewers that allows adding reviewers. I usually forget to set that and find it would be much easier if I could put that in the next step. It already lets me set the PR title and description. Would it be possible to add an additional field for reviewers?

I'd be happy to take a stab at it if you can point me in the right direction.

Thanks & Best Wishes,

@jainankit
Copy link
Contributor

Hi @drone-ah , thanks for offering to help on this. I think most folks don't choose a reviewer during PR creation.

So if you want to do this, I'd recommend adding a config in PullRequest context, that you can turn on, but would be false by default.

And then you can take a user input to collect reviewers in the process. The PR creation workflow is in:

func CreatePullRequest(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants