support Go to Definition at the right edge of identifiers #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviatesk
approved these changes
Jun 12, 2025
There was a problem hiding this comment.
LGTM. Thanks for fixing this quickly.
The test failure is due to JuliaLang/JuliaSyntax.jl#560, which requires some updates on the JL side. I confirmed this branch passes all the tests with the previous JS/JL commits.
We can pin JS/JL commits for now.
aviatesk
added a commit
that referenced
this pull request
Jun 12, 2025
Properly support cases like:
```julia
let
func│
end
```
aviatesk
added a commit
that referenced
this pull request
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go to Definition now works even when the cursor is placed just after an identifier, like:
If there's nothing suitable to the right of the cursor, the position just to the left (i.e., the right edge of
offset - 1) is also checked.