Skip to content

fix locking the Base.require_lock when using Base loading functions #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2025
Merged

fix locking the Base.require_lock when using Base loading functions #762

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/JETBase.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -893,18 +893,18 @@ function analyze_and_report_package!(interp::ConcreteInterpreter,
end

function find_pkg(pkgname::AbstractString)
pkgenv = Base.identify_package_env(pkgname)
pkgenv = @lock Base.require_lock Base.identify_package_env(pkgname)
isnothing(pkgenv) && error(lazy"Unknown package $pkgname.")
pkgid, env = pkgenv
filename = Base.locate_package(pkgid, env)
filename = @lock Base.require_lock Base.locate_package(pkgid, env)
isnothing(filename) && error(lazy"Expected $pkgname to have a source file.")
return (; pkgid, filename)
end

function find_pkg(pkgmod::Module)
filename = pathof(pkgmod)
isnothing(filename) && error(lazy"Cannot analyze a module defined in the REPL.")
pkgid = Base.identify_package(String(nameof(pkgmod)))
pkgid = @lock Base.require_lock Base.identify_package(String(nameof(pkgmod)))
isnothing(pkgid) && error(lazy"Expected $pkgmod to exist as a package.")
return (; pkgid, filename)
end
Expand Down
Loading