Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to LoweredCodeUtils 2.4 #591

Closed
wants to merge 7 commits into from
Closed

Bump to LoweredCodeUtils 2.4 #591

wants to merge 7 commits into from

Conversation

timholy
Copy link
Collaborator

@timholy timholy commented Jan 10, 2024

Control-flow analysis changed considerably in LoweredCodeUtils 2.4
(xref JuliaDebug/LoweredCodeUtils.jl#87).
This updates to the new version. The overall trend is less
reliance on norequire as a way of blocking certain "bad"
statements, instead attempting to discover minimal statements
purely by their dependencies.

Fixes #587

Control-flow analysis changed considerably  in LoweredCodeUtils 2.4
(xref JuliaDebug/LoweredCodeUtils.jl#87).
This updates to the new version. The overall trend is less
reliance on `norequire` as a way of blocking certain "bad"
statements, instead attempting to discover minimal statements
purely by their dependencies.
@timholy
Copy link
Collaborator Author

timholy commented Jan 10, 2024

Any thoughts on moving strongly_connected_components to LoweredCodeUtils? It seems likely to be useful there too.

@timholy
Copy link
Collaborator Author

timholy commented Jan 10, 2024

Hmm, those OutOfMemoryError errors are not promising. From browsing the history of CI they don't seem typical, so perhaps this change is causing them 😢

@timholy
Copy link
Collaborator Author

timholy commented Jan 10, 2024

Likely JuliaDebug/LoweredCodeUtils.jl#96

Copy link

github-actions bot commented Jan 10, 2024

JET Benchmark Result

Judge result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

  • Time of benchmarks:
  • Target: 10 Jan 2024 - 12:05
  • Baseline: 10 Jan 2024 - 12:16
  • Package commits:
  • Target: 442f7b
  • Baseline: 07d802
  • Julia commits:
  • Target: bf13a5
  • Baseline: bf13a5
  • Julia command flags:
  • Target: None
  • Baseline: None
  • Environment variables:
  • Target: None
  • Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID time ratio memory ratio
["First-Time-To-JET", "package loading"] 0.01 (5%) ✅ 0.32 (1%) ✅
["JETAnalyzer{SoundPass}", "sum(\"julia\") (cached)"] 1.06 (5%) ❌ 1.00 (1%)
["show(::IO, ::JETCallResult)", "report_opt"] 1.05 (5%) ❌ 1.00 (1%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["First-Time-To-JET"]
  • ["JETAnalyzer{BasicPass} top-level"]
  • ["JETAnalyzer{BasicPass}"]
  • ["JETAnalyzer{SoundPass}"]
  • ["OptAnalyzer"]
  • ["show(::IO, ::JETCallResult)"]

Julia versioninfo

Target

Julia Version 1.11.0-DEV.1245
Commit bf13a564c8e (2024-01-10 04:38 UTC)
Build Info:
 Official https://julialang.org/ release
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 22.04.3 LTS
 uname: Linux 6.2.0-1018-azure #18~22.04.1-Ubuntu SMP Tue Nov 21 19:25:02 UTC 2023 x86_64 x86_64
 CPU: AMD EPYC 7763 64-Core Processor: 
 speed user nice sys idle irq
 #1 2445 MHz 2554 s 0 s 162 s 5188 s 0 s
 #2 3243 MHz 3026 s 0 s 162 s 4717 s 0 s
 #3 3243 MHz 1578 s 0 s 190 s 6126 s 0 s
 #4 2652 MHz 953 s 0 s 187 s 6759 s 0 s
 Memory: 15.60690689086914 GB (11098.390625 MB free)
 Uptime: 793.87 sec
 Load Avg: 1.0 1.0 0.66
 WORD_SIZE: 64
 LLVM: libLLVM-16.0.6 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Baseline

Julia Version 1.11.0-DEV.1245
Commit bf13a564c8e (2024-01-10 04:38 UTC)
Build Info:
 Official https://julialang.org/ release
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 22.04.3 LTS
 uname: Linux 6.2.0-1018-azure #18~22.04.1-Ubuntu SMP Tue Nov 21 19:25:02 UTC 2023 x86_64 x86_64
 CPU: AMD EPYC 7763 64-Core Processor: 
 speed user nice sys idle irq
 #1 2591 MHz 4714 s 0 s 263 s 9665 s 0 s
 #2 2445 MHz 5425 s 0 s 259 s 8958 s 0 s
 #3 3242 MHz 3748 s 0 s 300 s 10583 s 0 s
 #4 2445 MHz 2140 s 0 s 303 s 12193 s 0 s
 Memory: 15.60690689086914 GB (11008.7265625 MB free)
 Uptime: 1469.17 sec
 Load Avg: 1.11 1.11 0.97
 WORD_SIZE: 64
 LLVM: libLLVM-16.0.6 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Target result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

  • Time of benchmark: 10 Jan 2024 - 12:5
  • Package commit: 442f7b
  • Julia commit: bf13a5
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["First-Time-To-JET", "package loading"] 814.515 ms (5%) 64.85 KiB (1%) 24
["First-Time-To-JET", "rand(Bool)"] 564.180 ms (5%) 65.26 KiB (1%) 24
["First-Time-To-JET", "sum(\"julia\")"] 213.515 ms (5%) 65.26 KiB (1%) 24
["JETAnalyzer{BasicPass} top-level", "demo"] 33.606 ms (5%) 2.13 MiB (1%) 44824
["JETAnalyzer{BasicPass} top-level", "self analysis"] 8.565 s (5%) 187.089 ms 1.56 GiB (1%) 34495919
["JETAnalyzer{BasicPass} top-level", "simple"] 9.143 ms (5%) 2.02 MiB (1%) 46348
["JETAnalyzer{BasicPass}", "identity(nothing)"] 73.989 μs (5%) 7.55 KiB (1%) 145
["JETAnalyzer{BasicPass}", "println(QuoteNode(nothing))"] 109.205 ms (5%) 37.46 MiB (1%) 880876
["JETAnalyzer{BasicPass}", "rand(Bool)"] 50.709 ms (5%) 17.29 MiB (1%) 404006
["JETAnalyzer{BasicPass}", "sum(\"julia\") (cached)"] 130.224 μs (5%) 15.05 KiB (1%) 257
["JETAnalyzer{BasicPass}", "sum(\"julia\")"] 5.801 ms (5%) 1.86 MiB (1%) 43308
["JETAnalyzer{SoundPass}", "identity(nothing)"] 73.688 μs (5%) 7.55 KiB (1%) 145
["JETAnalyzer{SoundPass}", "println(QuoteNode(nothing))"] 133.735 ms (5%) 51.17 MiB (1%) 979446
["JETAnalyzer{SoundPass}", "rand(Bool)"] 56.728 ms (5%) 19.39 MiB (1%) 426432
["JETAnalyzer{SoundPass}", "sum(\"julia\") (cached)"] 152.536 μs (5%) 17.67 KiB (1%) 290
["JETAnalyzer{SoundPass}", "sum(\"julia\")"] 6.731 ms (5%) 1.92 MiB (1%) 44462
["OptAnalyzer", "identity(nothing)"] 62.287 μs (5%) 6.06 KiB (1%) 132
["OptAnalyzer", "println(QuoteNode(nothing))"] 421.274 ms (5%) 261.78 MiB (1%) 5324644
["OptAnalyzer", "rand(Bool)"] 28.601 ms (5%) 18.42 MiB (1%) 392279
["OptAnalyzer", "sum(\"julia\") (cached)"] 220.684 μs (5%) 64.89 KiB (1%) 1140
["OptAnalyzer", "sum(\"julia\")"] 12.109 ms (5%) 8.11 MiB (1%) 170426
["show(::IO, ::JETCallResult)", "report_call"] 3.679 ms (5%) 1.14 MiB (1%) 9485
["show(::IO, ::JETCallResult)", "report_opt"] 14.166 μs (5%) 728 bytes (1%) 19

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["First-Time-To-JET"]
  • ["JETAnalyzer{BasicPass} top-level"]
  • ["JETAnalyzer{BasicPass}"]
  • ["JETAnalyzer{SoundPass}"]
  • ["OptAnalyzer"]
  • ["show(::IO, ::JETCallResult)"]

Julia versioninfo

Julia Version 1.11.0-DEV.1245
Commit bf13a564c8e (2024-01-10 04:38 UTC)
Build Info:
 Official https://julialang.org/ release
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 22.04.3 LTS
 uname: Linux 6.2.0-1018-azure #18~22.04.1-Ubuntu SMP Tue Nov 21 19:25:02 UTC 2023 x86_64 x86_64
 CPU: AMD EPYC 7763 64-Core Processor: 
 speed user nice sys idle irq
 #1 2445 MHz 2554 s 0 s 162 s 5188 s 0 s
 #2 3243 MHz 3026 s 0 s 162 s 4717 s 0 s
 #3 3243 MHz 1578 s 0 s 190 s 6126 s 0 s
 #4 2652 MHz 953 s 0 s 187 s 6759 s 0 s
 Memory: 15.60690689086914 GB (11098.390625 MB free)
 Uptime: 793.87 sec
 Load Avg: 1.0 1.0 0.66
 WORD_SIZE: 64
 LLVM: libLLVM-16.0.6 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Baseline result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

  • Time of benchmark: 10 Jan 2024 - 12:16
  • Package commit: 07d802
  • Julia commit: bf13a5
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["First-Time-To-JET", "package loading"] 66.761 s (5%) 201.41 KiB (1%) 2679
["First-Time-To-JET", "rand(Bool)"] 564.680 ms (5%) 65.26 KiB (1%) 24
["First-Time-To-JET", "sum(\"julia\")"] 215.756 ms (5%) 65.26 KiB (1%) 24
["JETAnalyzer{BasicPass} top-level", "demo"] 33.085 ms (5%) 2.12 MiB (1%) 44463
["JETAnalyzer{BasicPass} top-level", "self analysis"] 8.622 s (5%) 188.951 ms 1.56 GiB (1%) 34508505
["JETAnalyzer{BasicPass} top-level", "simple"] 9.226 ms (5%) 2.00 MiB (1%) 46300
["JETAnalyzer{BasicPass}", "identity(nothing)"] 75.541 μs (5%) 7.55 KiB (1%) 145
["JETAnalyzer{BasicPass}", "println(QuoteNode(nothing))"] 107.584 ms (5%) 37.46 MiB (1%) 880877
["JETAnalyzer{BasicPass}", "rand(Bool)"] 50.670 ms (5%) 17.29 MiB (1%) 404007
["JETAnalyzer{BasicPass}", "sum(\"julia\") (cached)"] 124.302 μs (5%) 15.05 KiB (1%) 257
["JETAnalyzer{BasicPass}", "sum(\"julia\")"] 5.895 ms (5%) 1.86 MiB (1%) 43308
["JETAnalyzer{SoundPass}", "identity(nothing)"] 72.856 μs (5%) 7.55 KiB (1%) 145
["JETAnalyzer{SoundPass}", "println(QuoteNode(nothing))"] 133.001 ms (5%) 51.30 MiB (1%) 979475
["JETAnalyzer{SoundPass}", "rand(Bool)"] 56.137 ms (5%) 19.42 MiB (1%) 426445
["JETAnalyzer{SoundPass}", "sum(\"julia\") (cached)"] 143.819 μs (5%) 17.67 KiB (1%) 290
["JETAnalyzer{SoundPass}", "sum(\"julia\")"] 6.517 ms (5%) 1.90 MiB (1%) 44460
["OptAnalyzer", "identity(nothing)"] 61.996 μs (5%) 6.06 KiB (1%) 132
["OptAnalyzer", "println(QuoteNode(nothing))"] 411.590 ms (5%) 261.78 MiB (1%) 5324655
["OptAnalyzer", "rand(Bool)"] 28.573 ms (5%) 18.42 MiB (1%) 392280
["OptAnalyzer", "sum(\"julia\") (cached)"] 222.146 μs (5%) 64.89 KiB (1%) 1140
["OptAnalyzer", "sum(\"julia\")"] 12.138 ms (5%) 8.11 MiB (1%) 170426
["show(::IO, ::JETCallResult)", "report_call"] 3.613 ms (5%) 1.14 MiB (1%) 9485
["show(::IO, ::JETCallResult)", "report_opt"] 13.485 μs (5%) 728 bytes (1%) 19

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["First-Time-To-JET"]
  • ["JETAnalyzer{BasicPass} top-level"]
  • ["JETAnalyzer{BasicPass}"]
  • ["JETAnalyzer{SoundPass}"]
  • ["OptAnalyzer"]
  • ["show(::IO, ::JETCallResult)"]

Julia versioninfo

Julia Version 1.11.0-DEV.1245
Commit bf13a564c8e (2024-01-10 04:38 UTC)
Build Info:
 Official https://julialang.org/ release
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 22.04.3 LTS
 uname: Linux 6.2.0-1018-azure #18~22.04.1-Ubuntu SMP Tue Nov 21 19:25:02 UTC 2023 x86_64 x86_64
 CPU: AMD EPYC 7763 64-Core Processor: 
 speed user nice sys idle irq
 #1 2591 MHz 4714 s 0 s 263 s 9665 s 0 s
 #2 2445 MHz 5425 s 0 s 259 s 8958 s 0 s
 #3 3242 MHz 3748 s 0 s 300 s 10583 s 0 s
 #4 2445 MHz 2140 s 0 s 303 s 12193 s 0 s
 Memory: 15.60690689086914 GB (11008.7265625 MB free)
 Uptime: 1469.17 sec
 Load Avg: 1.11 1.11 0.97
 WORD_SIZE: 64
 LLVM: libLLVM-16.0.6 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Runtime information

Runtime Info
BLAS #threads 2
BLAS.vendor() lbt
Sys.CPU_THREADS 4

lscpu output:

Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Address sizes: 48 bits physical, 48 bits virtual
Byte Order: Little Endian
CPU(s): 4
On-line CPU(s) list: 0-3
Vendor ID: AuthenticAMD
Model name: AMD EPYC 7763 64-Core Processor
CPU family: 25
Model: 1
Thread(s) per core: 2
Core(s) per socket: 2
Socket(s): 1
Stepping: 1
BogoMIPS: 4890.85
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rdtscp lm constant_tsc rep_good nopl tsc_reliable nonstop_tsc cpuid extd_apicid aperfmperf pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm cmp_legacy svm cr8_legacy abm sse4a misalignsse 3dnowprefetch osvw topoext invpcid_single vmmcall fsgsbase bmi1 avx2 smep bmi2 erms invpcid rdseed adx smap clflushopt clwb sha_ni xsaveopt xsavec xgetbv1 xsaves clzero xsaveerptr rdpru arat npt nrip_save tsc_scale vmcb_clean flushbyasid decodeassists pausefilter pfthreshold v_vmsave_vmload umip vaes vpclmulqdq rdpid fsrm
Virtualization: AMD-V
Hypervisor vendor: Microsoft
Virtualization type: full
L1d cache: 64 KiB (2 instances)
L1i cache: 64 KiB (2 instances)
L2 cache: 1 MiB (2 instances)
L3 cache: 32 MiB (1 instance)
NUMA node(s): 1
NUMA node0 CPU(s): 0-3
Vulnerability Gather data sampling: Not affected
Vulnerability Itlb multihit: Not affected
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Mmio stale data: Not affected
Vulnerability Retbleed: Not affected
Vulnerability Spec rstack overflow: Mitigation; safe RET, no microcode
Vulnerability Spec store bypass: Vulnerable
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; Retpolines, STIBP disabled, RSB filling, PBRSB-eIBRS Not affected
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Not affected

Cpu Property Value
Brand AMD EPYC 7763 64-Core Processor
Vendor :AMD
Architecture :Unknown
Model Family: 0xaf, Model: 0x01, Stepping: 0x01, Type: 0x00
Cores 16 physical cores, 16 logical cores (on executing CPU)
No Hyperthreading hardware capability detected
Clock Frequencies Not supported by CPU
Data Cache Level 1:3 : (32, 512, 32768) kbytes
64 byte cache line size
Address Size 48 bits virtual, 48 bits physical
SIMD 256 bit = 32 byte max. SIMD vector size
Time Stamp Counter TSC is accessible via rdtsc
TSC runs at constant rate (invariant from clock frequency)
Perf. Monitoring Performance Monitoring Counters (PMC) are not supported
Hypervisor Yes, Microsoft
JET Benchmark Result

Judge result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

  • Time of benchmarks:
  • Target: 16 Jan 2024 - 06:33
  • Baseline: 16 Jan 2024 - 06:45
  • Package commits:
  • Target: ec69be
  • Baseline: f40e2f
  • Julia commits:
  • Target: b05814
  • Baseline: b05814
  • Julia command flags:
  • Target: None
  • Baseline: None
  • Environment variables:
  • Target: None
  • Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID time ratio memory ratio
["First-Time-To-JET", "package loading"] 0.79 (5%) ✅ 1.00 (1%)
["JETAnalyzer{BasicPass} top-level", "simple"] 1.07 (5%) ❌ 1.00 (1%)
["JETAnalyzer{BasicPass}", "sum(\"julia\") (cached)"] 0.93 (5%) ✅ 1.00 (1%)
["JETAnalyzer{SoundPass}", "identity(nothing)"] 1.09 (5%) ❌ 1.00 (1%)
["OptAnalyzer", "identity(nothing)"] 0.85 (5%) ✅ 1.00 (1%)
["show(::IO, ::JETCallResult)", "report_call"] 0.93 (5%) ✅ 1.00 (1%)
["show(::IO, ::JETCallResult)", "report_opt"] 0.76 (5%) ✅ 1.00 (1%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["First-Time-To-JET"]
  • ["JETAnalyzer{BasicPass} top-level"]
  • ["JETAnalyzer{BasicPass}"]
  • ["JETAnalyzer{SoundPass}"]
  • ["OptAnalyzer"]
  • ["show(::IO, ::JETCallResult)"]

Julia versioninfo

Target

Julia Version 1.11.0-DEV.1279
Commit b058146cafe (2024-01-16 01:18 UTC)
Build Info:
 Official https://julialang.org/ release
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 22.04.3 LTS
 uname: Linux 6.2.0-1018-azure #18~22.04.1-Ubuntu SMP Tue Nov 21 19:25:02 UTC 2023 x86_64 x86_64
 CPU: AMD EPYC 7763 64-Core Processor: 
 speed user nice sys idle irq
 #1 3244 MHz 2212 s 0 s 155 s 5664 s 0 s
 #2 2445 MHz 2550 s 0 s 147 s 5330 s 0 s
 #3 2582 MHz 1752 s 0 s 175 s 6101 s 0 s
 #4 3243 MHz 2110 s 0 s 167 s 5752 s 0 s
 Memory: 15.606903076171875 GB (11397.546875 MB free)
 Uptime: 806.85 sec
 Load Avg: 1.12 1.05 0.68
 WORD_SIZE: 64
 LLVM: libLLVM-16.0.6 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Baseline

Julia Version 1.11.0-DEV.1279
Commit b058146cafe (2024-01-16 01:18 UTC)
Build Info:
 Official https://julialang.org/ release
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 22.04.3 LTS
 uname: Linux 6.2.0-1018-azure #18~22.04.1-Ubuntu SMP Tue Nov 21 19:25:02 UTC 2023 x86_64 x86_64
 CPU: AMD EPYC 7763 64-Core Processor: 
 speed user nice sys idle irq
 #1 2445 MHz 3759 s 0 s 265 s 10948 s 0 s
 #2 2591 MHz 4672 s 0 s 248 s 10053 s 0 s
 #3 3243 MHz 4002 s 0 s 294 s 10678 s 0 s
 #4 2445 MHz 4365 s 0 s 261 s 10348 s 0 s
 Memory: 15.606903076171875 GB (11333.9375 MB free)
 Uptime: 1502.84 sec
 Load Avg: 1.01 1.1 0.99
 WORD_SIZE: 64
 LLVM: libLLVM-16.0.6 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Target result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

  • Time of benchmark: 16 Jan 2024 - 6:33
  • Package commit: ec69be
  • Julia commit: b05814
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["First-Time-To-JET", "package loading"] 60.061 s (5%) 199.84 KiB (1%) 2646
["First-Time-To-JET", "rand(Bool)"] 576.597 ms (5%) 65.26 KiB (1%) 24
["First-Time-To-JET", "sum(\"julia\")"] 210.267 ms (5%) 65.26 KiB (1%) 24
["JETAnalyzer{BasicPass} top-level", "demo"] 35.432 ms (5%) 2.10 MiB (1%) 44497
["JETAnalyzer{BasicPass} top-level", "self analysis"] 7.575 s (5%) 1.33 GiB (1%) 29318241
["JETAnalyzer{BasicPass} top-level", "simple"] 10.279 ms (5%) 2.00 MiB (1%) 46236
["JETAnalyzer{BasicPass}", "identity(nothing)"] 100.779 μs (5%) 7.55 KiB (1%) 145
["JETAnalyzer{BasicPass}", "println(QuoteNode(nothing))"] 115.484 ms (5%) 37.48 MiB (1%) 881552
["JETAnalyzer{BasicPass}", "rand(Bool)"] 53.681 ms (5%) 17.30 MiB (1%) 404113
["JETAnalyzer{BasicPass}", "sum(\"julia\") (cached)"] 128.661 μs (5%) 15.05 KiB (1%) 257
["JETAnalyzer{BasicPass}", "sum(\"julia\")"] 6.221 ms (5%) 1.86 MiB (1%) 43308
["JETAnalyzer{SoundPass}", "identity(nothing)"] 107.311 μs (5%) 7.55 KiB (1%) 145
["JETAnalyzer{SoundPass}", "println(QuoteNode(nothing))"] 141.610 ms (5%) 51.20 MiB (1%) 980122
["JETAnalyzer{SoundPass}", "rand(Bool)"] 57.861 ms (5%) 19.40 MiB (1%) 426539
["JETAnalyzer{SoundPass}", "sum(\"julia\") (cached)"] 155.301 μs (5%) 17.67 KiB (1%) 290
["JETAnalyzer{SoundPass}", "sum(\"julia\")"] 6.965 ms (5%) 1.92 MiB (1%) 44462
["OptAnalyzer", "identity(nothing)"] 71.844 μs (5%) 6.25 KiB (1%) 136
["OptAnalyzer", "println(QuoteNode(nothing))"] 420.648 ms (5%) 257.32 MiB (1%) 5226859
["OptAnalyzer", "rand(Bool)"] 28.923 ms (5%) 18.13 MiB (1%) 381917
["OptAnalyzer", "sum(\"julia\") (cached)"] 225.613 μs (5%) 63.14 KiB (1%) 1108
["OptAnalyzer", "sum(\"julia\")"] 12.239 ms (5%) 7.97 MiB (1%) 165844
["show(::IO, ::JETCallResult)", "report_call"] 3.596 ms (5%) 1.14 MiB (1%) 9485
["show(::IO, ::JETCallResult)", "report_opt"] 12.153 μs (5%) 728 bytes (1%) 19

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["First-Time-To-JET"]
  • ["JETAnalyzer{BasicPass} top-level"]
  • ["JETAnalyzer{BasicPass}"]
  • ["JETAnalyzer{SoundPass}"]
  • ["OptAnalyzer"]
  • ["show(::IO, ::JETCallResult)"]

Julia versioninfo

Julia Version 1.11.0-DEV.1279
Commit b058146cafe (2024-01-16 01:18 UTC)
Build Info:
 Official https://julialang.org/ release
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 22.04.3 LTS
 uname: Linux 6.2.0-1018-azure #18~22.04.1-Ubuntu SMP Tue Nov 21 19:25:02 UTC 2023 x86_64 x86_64
 CPU: AMD EPYC 7763 64-Core Processor: 
 speed user nice sys idle irq
 #1 3244 MHz 2212 s 0 s 155 s 5664 s 0 s
 #2 2445 MHz 2550 s 0 s 147 s 5330 s 0 s
 #3 2582 MHz 1752 s 0 s 175 s 6101 s 0 s
 #4 3243 MHz 2110 s 0 s 167 s 5752 s 0 s
 Memory: 15.606903076171875 GB (11397.546875 MB free)
 Uptime: 806.85 sec
 Load Avg: 1.12 1.05 0.68
 WORD_SIZE: 64
 LLVM: libLLVM-16.0.6 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Baseline result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

  • Time of benchmark: 16 Jan 2024 - 6:45
  • Package commit: f40e2f
  • Julia commit: b05814
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["First-Time-To-JET", "package loading"] 75.878 s (5%) 199.84 KiB (1%) 2646
["First-Time-To-JET", "rand(Bool)"] 571.460 ms (5%) 65.26 KiB (1%) 24
["First-Time-To-JET", "sum(\"julia\")"] 201.438 ms (5%) 65.26 KiB (1%) 24
["JETAnalyzer{BasicPass} top-level", "demo"] 33.758 ms (5%) 2.09 MiB (1%) 44136
["JETAnalyzer{BasicPass} top-level", "self analysis"] 7.236 s (5%) 350.696 ms 1.33 GiB (1%) 29330820
["JETAnalyzer{BasicPass} top-level", "simple"] 9.585 ms (5%) 2.00 MiB (1%) 46190
["JETAnalyzer{BasicPass}", "identity(nothing)"] 96.330 μs (5%) 7.55 KiB (1%) 145
["JETAnalyzer{BasicPass}", "println(QuoteNode(nothing))"] 114.070 ms (5%) 37.48 MiB (1%) 881551
["JETAnalyzer{BasicPass}", "rand(Bool)"] 52.898 ms (5%) 17.30 MiB (1%) 404112
["JETAnalyzer{BasicPass}", "sum(\"julia\") (cached)"] 137.898 μs (5%) 15.05 KiB (1%) 257
["JETAnalyzer{BasicPass}", "sum(\"julia\")"] 6.082 ms (5%) 1.86 MiB (1%) 43308
["JETAnalyzer{SoundPass}", "identity(nothing)"] 98.284 μs (5%) 7.55 KiB (1%) 145
["JETAnalyzer{SoundPass}", "println(QuoteNode(nothing))"] 141.132 ms (5%) 51.29 MiB (1%) 980133
["JETAnalyzer{SoundPass}", "rand(Bool)"] 59.679 ms (5%) 19.40 MiB (1%) 426538
["JETAnalyzer{SoundPass}", "sum(\"julia\") (cached)"] 150.783 μs (5%) 17.67 KiB (1%) 290
["JETAnalyzer{SoundPass}", "sum(\"julia\")"] 7.006 ms (5%) 1.92 MiB (1%) 44462
["OptAnalyzer", "identity(nothing)"] 84.338 μs (5%) 6.25 KiB (1%) 136
["OptAnalyzer", "println(QuoteNode(nothing))"] 440.706 ms (5%) 257.37 MiB (1%) 5226858
["OptAnalyzer", "rand(Bool)"] 29.524 ms (5%) 18.13 MiB (1%) 381916
["OptAnalyzer", "sum(\"julia\") (cached)"] 220.153 μs (5%) 63.14 KiB (1%) 1108
["OptAnalyzer", "sum(\"julia\")"] 12.559 ms (5%) 7.97 MiB (1%) 165844
["show(::IO, ::JETCallResult)", "report_call"] 3.868 ms (5%) 1.14 MiB (1%) 9485
["show(::IO, ::JETCallResult)", "report_opt"] 15.981 μs (5%) 728 bytes (1%) 19

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["First-Time-To-JET"]
  • ["JETAnalyzer{BasicPass} top-level"]
  • ["JETAnalyzer{BasicPass}"]
  • ["JETAnalyzer{SoundPass}"]
  • ["OptAnalyzer"]
  • ["show(::IO, ::JETCallResult)"]

Julia versioninfo

Julia Version 1.11.0-DEV.1279
Commit b058146cafe (2024-01-16 01:18 UTC)
Build Info:
 Official https://julialang.org/ release
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 22.04.3 LTS
 uname: Linux 6.2.0-1018-azure #18~22.04.1-Ubuntu SMP Tue Nov 21 19:25:02 UTC 2023 x86_64 x86_64
 CPU: AMD EPYC 7763 64-Core Processor: 
 speed user nice sys idle irq
 #1 2445 MHz 3759 s 0 s 265 s 10948 s 0 s
 #2 2591 MHz 4672 s 0 s 248 s 10053 s 0 s
 #3 3243 MHz 4002 s 0 s 294 s 10678 s 0 s
 #4 2445 MHz 4365 s 0 s 261 s 10348 s 0 s
 Memory: 15.606903076171875 GB (11333.9375 MB free)
 Uptime: 1502.84 sec
 Load Avg: 1.01 1.1 0.99
 WORD_SIZE: 64
 LLVM: libLLVM-16.0.6 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Runtime information

Runtime Info
BLAS #threads 2
BLAS.vendor() lbt
Sys.CPU_THREADS 4

lscpu output:

Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Address sizes: 48 bits physical, 48 bits virtual
Byte Order: Little Endian
CPU(s): 4
On-line CPU(s) list: 0-3
Vendor ID: AuthenticAMD
Model name: AMD EPYC 7763 64-Core Processor
CPU family: 25
Model: 1
Thread(s) per core: 2
Core(s) per socket: 2
Socket(s): 1
Stepping: 1
BogoMIPS: 4890.85
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rdtscp lm constant_tsc rep_good nopl tsc_reliable nonstop_tsc cpuid extd_apicid aperfmperf pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm cmp_legacy svm cr8_legacy abm sse4a misalignsse 3dnowprefetch osvw topoext invpcid_single vmmcall fsgsbase bmi1 avx2 smep bmi2 erms invpcid rdseed adx smap clflushopt clwb sha_ni xsaveopt xsavec xgetbv1 xsaves clzero xsaveerptr rdpru arat npt nrip_save tsc_scale vmcb_clean flushbyasid decodeassists pausefilter pfthreshold v_vmsave_vmload umip vaes vpclmulqdq rdpid fsrm
Virtualization: AMD-V
Hypervisor vendor: Microsoft
Virtualization type: full
L1d cache: 64 KiB (2 instances)
L1i cache: 64 KiB (2 instances)
L2 cache: 1 MiB (2 instances)
L3 cache: 32 MiB (1 instance)
NUMA node(s): 1
NUMA node0 CPU(s): 0-3
Vulnerability Gather data sampling: Not affected
Vulnerability Itlb multihit: Not affected
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Mmio stale data: Not affected
Vulnerability Retbleed: Not affected
Vulnerability Spec rstack overflow: Mitigation; safe RET, no microcode
Vulnerability Spec store bypass: Vulnerable
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; Retpolines, STIBP disabled, RSB filling, PBRSB-eIBRS Not affected
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Not affected

Cpu Property Value
Brand AMD EPYC 7763 64-Core Processor
Vendor :AMD
Architecture :Unknown
Model Family: 0xaf, Model: 0x01, Stepping: 0x01, Type: 0x00
Cores 16 physical cores, 16 logical cores (on executing CPU)
No Hyperthreading hardware capability detected
Clock Frequencies Not supported by CPU
Data Cache Level 1:3 : (32, 512, 32768) kbytes
64 byte cache line size
Address Size 48 bits virtual, 48 bits physical
SIMD 256 bit = 32 byte max. SIMD vector size
Time Stamp Counter TSC is accessible via rdtsc
TSC runs at constant rate (invariant from clock frequency)
Perf. Monitoring Performance Monitoring Counters (PMC) are not supported
Hypervisor Yes, Microsoft

@aviatesk
Copy link
Owner

Thanks for the update! I had been delaying the LCT update, so this is very helpful.

The overall trend is less
reliance on norequire as a way of blocking certain "bad"
statements, instead attempting to discover minimal statements
purely by their dependencies.

I believe this is a positive trend.

Any thoughts on moving strongly_connected_components to LoweredCodeUtils? It seems likely to be useful there too.

Absolutely! This is code I originally adapted from LightGraphs.jl a while back. While it doesn't have its own unit tests, it has been bug-free in JET's functionality so far. I'll review the most recent code from Graphs.jl and then attempt to create a PR to LCU.

Control-flow analysis changed considerably  in LoweredCodeUtils 2.4
(xref JuliaDebug/LoweredCodeUtils.jl#87).
This updates to the new version. The overall trend is less
reliance on `norequire` as a way of blocking certain "bad"
statements, instead attempting to discover minimal statements
purely by their dependencies.
@timholy
Copy link
Collaborator Author

timholy commented Jan 22, 2024

Well, at least we don't get out of memory errors. I don't have time to dig into the failures any more today but I am interested in figuring out why things are failing, it could reveal further issues with LCU's current strategy.

@aviatesk
Copy link
Owner

Thanks! I can look into these sometime this week. I am also planning to take a look on your PRs on LCU side again too.

@fingolfin
Copy link

Would be nice to get this to hopefully unbreak JET on Julia master (at least it needs a newer LCU for master, not sure if that's already sufficient)

@aviatesk aviatesk deleted the teh/lcu2.4 branch May 20, 2024 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MethodError: no method matching add_control_flow!(::BitVector, ::Core.Compiler.CFG, ::BitSet)
3 participants