Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Cargo Dependencies #9

Merged
merged 2 commits into from
Mar 2, 2021

Conversation

optikfluffel
Copy link
Contributor

  • bump Cargo dependencies
  • rename FastRss to FastRSS
  • bump version to 0.3.6

@praveenperera
Copy link
Member

praveenperera commented Mar 2, 2021

Hey @optikfluffel, thanks for this. I like bumping the cargo deps. But changing the name to FastRSS would be breaking.

I don't want to do that right now, and if I do I would want to bump the version to 0.4.0.

Can you rebase and make the cargo related changes only.

@optikfluffel
Copy link
Contributor Author

@praveenperera Ok then, I'll revert this back to FastRss later today.
I thought this was a mistake btw, because in lib/fast_rss.ex it's called FastRSS but not in mix.exs and the test file (which currently doesn't seem to do anything anyway).

@praveenperera
Copy link
Member

praveenperera commented Mar 2, 2021

Oh you're right my mistake its called FastRSS in the module its being called so it shouldn't be breaking.

Thanks, I will merge as is.

@praveenperera praveenperera merged commit ac74e72 into avencera:master Mar 2, 2021
@optikfluffel optikfluffel deleted the bump-cargo-dependencies branch March 2, 2021 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants