Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lz fix too many imports #917

Merged
merged 3 commits into from
Jan 25, 2021
Merged

Lz fix too many imports #917

merged 3 commits into from
Jan 25, 2021

Conversation

ladislav-zezula
Copy link
Contributor

No description provided.

s3rvac
s3rvac reviewed Jan 24, 2021
View reviewed changes
Copy link
Member

@s3rvac s3rvac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix. I am not approving yet as there are some remarks that I would like to discuss.

include/retdec/pelib/ImportDirectory.h Outdated Show resolved Hide resolved
include/retdec/pelib/ImportDirectory.h Show resolved Hide resolved
include/retdec/pelib/ImportDirectory.h Outdated Show resolved Hide resolved
s3rvac
s3rvac approved these changes Jan 25, 2021
View reviewed changes
Copy link
Member

@s3rvac s3rvac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the improvement 👍 The code LGTM and tests are passing, so I am going to merge the PR.

@s3rvac s3rvac merged commit 60c94e5 into master Jan 25, 2021
@s3rvac s3rvac deleted the LZ_fix_too_many_imports branch January 25, 2021 11:44
s3rvac added a commit that referenced this pull request Jan 25, 2021
@s3rvac
Add a CHANGELOG entry for #917.
6ed327e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s3rvac s3rvac s3rvac approved these changes

Assignees

@s3rvac s3rvac

Labels
C-fileinfo enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ladislav-zezula @s3rvac