Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Packer Detection: Added more packers #607

Merged
merged 7 commits into from
Jul 10, 2019
Merged

Packer Detection: Added more packers #607

merged 7 commits into from
Jul 10, 2019

Conversation

ladislav-zezula
Copy link
Contributor

No description provided.

Zezula Ladislav added 2 commits July 8, 2019 08:37
s3rvac
s3rvac requested changes Jul 10, 2019
View reviewed changes
Copy link
Member

@s3rvac s3rvac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the added packer detections 👍 I have reviewed the code since @metthal is at a conference. There are several suggestions that I would like you to consider.

include/retdec/cpdetect/compiler_detector/heuristics/pe_heuristics.h Show resolved Hide resolved
include/retdec/cpdetect/cptypes.h Show resolved Hide resolved
src/cpdetect/compiler_detector/heuristics/pe_heuristics.cpp Outdated Show resolved Hide resolved
src/cpdetect/compiler_detector/heuristics/pe_heuristics.cpp Outdated Show resolved Hide resolved
src/cpdetect/compiler_detector/heuristics/pe_heuristics.cpp Show resolved Hide resolved
include/retdec/cpdetect/compiler_detector/heuristics/pe_heuristics.h Show resolved Hide resolved
src/cpdetect/compiler_detector/heuristics/pe_heuristics.cpp Outdated Show resolved Hide resolved
src/cpdetect/compiler_detector/heuristics/pe_heuristics.cpp Show resolved Hide resolved
src/cpdetect/compiler_detector/heuristics/pe_heuristics.cpp Outdated Show resolved Hide resolved
src/cpdetect/compiler_detector/heuristics/pe_heuristics.cpp Outdated Show resolved Hide resolved
@s3rvac s3rvac requested review from s3rvac and removed request for metthal July 10, 2019 10:49
@s3rvac s3rvac assigned s3rvac and unassigned metthal Jul 10, 2019
s3rvac
s3rvac approved these changes Jul 10, 2019
View reviewed changes
Copy link
Member

@s3rvac s3rvac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fixes 👍 I am going to merge this PR and avast/retdec-regression-tests#33.

@s3rvac s3rvac merged commit 24b07d6 into master Jul 10, 2019
s3rvac added a commit that referenced this pull request Jul 10, 2019
@s3rvac
Add a CHANGELOG entry for #607.
fbbad8e
@s3rvac s3rvac deleted the LZ_PackerDetection branch July 11, 2019 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s3rvac s3rvac s3rvac approved these changes

Assignees

@s3rvac s3rvac

Labels
C-cpdetect enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ladislav-zezula @s3rvac @metthal