TypeRef table reconstruction SEGFAULT fix #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s3rvac
reviewed
Feb 26, 2019
| @@ -840,6 +840,12 @@ std::unique_ptr<DotnetClass> DotnetTypeReconstructor::createClassReference(const | |||
| else | |||
| { | |||
| auto assemblyRefTable = static_cast<const MetadataTable<AssemblyRef>*>(metadataStream->getMetadataTable(MetadataTableType::AssemblyRef)); | |||
|
|
|||
| if (!assemblyRefTable) | |||
There was a problem hiding this comment.
Would it be possible/desirable to create a regression test for fileinfo from of the input binaries from #458? For example from the smaller one.
There was a problem hiding this comment.
Sure, unfortunately the smaller binary contains no parsable TypeRefTable, therefore i made RT with the bigger one. avast/retdec-regression-tests#19
|
Thanks for fix. LGTM but add regression test for the smallest binary from #458 and that's all. |
metthal
approved these changes
Feb 26, 2019
s3rvac
added a commit
that referenced
this pull request
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#458
I've added a check for null in TypeRef table reconstruction to prevenet null dereference.