Added option -l --list to retdec-bin2pat. #484
Conversation
|
@s3rvac Thank you for taking the time to put so much detail into reviewing this. I must be honest, when I awoke to the email notification I had an enormous grin on my face. I have not seen such a list of required changes since I took my introductory to C++ course. I will amend the commit this afternoon. With regard to using json, I must confess that this is a case of using it because it was there. I should have followed the golden rule of 'keep it simple, stupid'. Thinking about it again, its use just adds overhead and consumes more memory than necessary. Considering that a user is unlikely to try to pass a huge list of objects manually, is it necessary to even have the option appear when the help is displayed? Do you have a suggestion for the command-line option? |
astrelsky
changed the title
astrelsky
force-pushed
the
master
branch
2 times, most recently
from
749ab4e
to
6b55661
Compare
The added option -l --list is being used to pass the list of objects from retdec-signature-from-library-creator.py as a text file. Resolves avast#472
The added option -l --list is being used to pass the list of objects
from retdec-signature-from-library-creator.py as a json file.
Resolves #472
I am uncertain if the change in retdec-bin2pat's help output correctly
follows the Utility Conventions. If it does not, providing a proper
reference would be appreciated.
Regards,
Andrew Strelsky