Disable forced reconfiguration of LLVM to speed up build and installation #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tallation. This was a relict from our old build system, where we built LLVM as an external project from a subdirectory and needed to detect changes in its source files. Now, we build LLVM as an external project from a GitHub URL, so there is no longer a need to re-configure LLVM after it has been built (its sources will never change). This speeds up the rebuild and installation of RetDec. For example, on my Linux machine, a rebuild without changes has speeded up from real 0m1.223s user 0m2.956s sys 0m1.163s to real 0m0.527s user 0m1.903s sys 0m0.716s On Windows, the difference will be even bigger. This lowering of rebuild times is very handy during development.
PeterMatula
approved these changes
May 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a relict from our old build system, where we built LLVM as an external project from a subdirectory and needed to detect changes in its source files. Now, we build LLVM as an external project from a GitHub URL, so there is no longer a need to re-configure LLVM after it has been built (its sources will never change).
This speeds up the rebuild and installation of RetDec. For example, on my Linux machine, a rebuild without changes has speeded up from
to
On Windows, the difference will be even bigger. This lowering of rebuild times is very handy during development.