Integrate new authenticode parser #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I feel like Teamcity is not using the branch in regression-tests 🤔 |
PeterMatula
approved these changes
Oct 25, 2021
| @@ -14,6 +14,7 @@ endif() | |||
| set(MSVC_GE $<BOOL:${MSVC}>) | |||
| set(MSVC_CONFIG $<${MSVC_GE}:$<CONFIG>/>) | |||
|
|
|||
| add_subdirectory(authenticode-parser) | |||
There was a problem hiding this comment.
Just for future reference, 1) this should also be added conditionaly (I will fix it in master and send you a commit), 2) It would be easier for me to modify it if you used the avast/retdec directly instead of your own fork, now that you have the rights. Maybe I could somehow modify your fork or this PR, but it complicates the things.
There was a problem hiding this comment.
Thanks!, okay, I'll switch to avast/retdec repository for future
PeterMatula
added a commit
that referenced
this pull request
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the current C++ Authenticode parser with https://github.com/avast/authenticode-parser
There are 2 main differences in the output:
The new parser is also able to extract more nested signatures as it treats nested signatures correctly as a Set. But because the library doesn't have access to the PE file, I've moved the file digest calculation into the
pe_format.cpp.