retdec-archive-decompiler.sh does not append ".c" at the end of the decompiled files

[s3rvac]

The retdec-archive-decompiler.sh script does not append .c at the end of the decompiled files from the input archive.

Input

Run

retdec-archive-decompiler.sh FILE

where FILE is e.g. gnu.a from our regression-tests suite. You can take any archive you want as the issue does not depend on the input archive.

Output

Among other files, the command generates the following two files, which contain the decompiled C code:

gnu.a.file_1
gnu.a.file_2

Notice that the files do not have any extension.

Expected output

The generated files should end with .c, just like when you run retdec-decompiler.sh:

gnu.a.file_1.c
gnu.a.file_2.c

Configuration

• Commit: ae9a6d4 (current master)
• 64b Arch Linux, GCC 7.3.1, Debug build of RetDec

[s3rvac]

I have analyzed this. In scripts/retdec-archive-decompiler.sh, we call retdec-decompiler.sh for each file in the archive:

gnutimeout $TIMEOUT "$DECOMPILER_SH" --ar-index="$INDEX" -o "$LIBRARY_PATH.file_$FILE_INDEX" "$LIBRARY_PATH" $DECOMPILER_SH_ARGS > "$LOG_FILE" 2>&1

However, when specifying the output file via -o, we do not append the extension based on the selected high-level language (.c or .py, depending on -l/--target-language).

[s3rvac]

Fixed in c924fea.