Fixed RETDEC-74 and RETDEC-61 #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterMatula
reviewed
Aug 23, 2021
There was a problem hiding this comment.
I have some questions in comments and also some more:
- There are samples in RETDEC-74, but no new samples added to tests in here. Is everything modified tested using already existing samples? Shouldn't we add more?
- RETDEC-61 is talking about some ordinal hints, but I don't see anything related to this in here. However, I may not be familiar enough with the problem to know what it actually wanted to achieve.
I admit I'm not super familiar with this, so It may all be just fine. Anyway, If it would be too long to explain it to me in comments, we can do a short call tomorrow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.