Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[36] – Feature: Polling #72

Merged
merged 9 commits into from
Aug 6, 2024
Merged

[36] – Feature: Polling #72

merged 9 commits into from
Aug 6, 2024

Conversation

Drish-xD
Copy link
Collaborator

@Drish-xD Drish-xD commented Jul 25, 2024

Implemented polling strategy to ensure the data displayed in the UI is always up-to-date, enhancing the overall responsiveness and speed of the user interface.

Use Constant POLLING_INTERVAL to change the interval timing.
Current its 30 sec

Disabled edit if the session is in pending state.

@Drish-xD Drish-xD linked an issue Jul 25, 2024 that may be closed by this pull request
@Drish-xD Drish-xD self-assigned this Jul 25, 2024
@Drish-xD Drish-xD added the enhancement New feature or request label Jul 25, 2024
export const DATA_PER_PAGE = 50;
export const PAGE_SIZE_OPTIONS = [10, 25, 50, 100, 200];

// TABLE POLLING CONSTANTS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can improve this maybe. we are sure the lambda function takes ~30 sec to run... so maybe in the interval [20, 60] seconds we need to poll more frequently. can schedule it better

Copy link
Contributor

@suryabulusu suryabulusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a comment.. do write a description of PR

  • do we also "gray" the row to indicate pending status ? or no need? up to you

@Drish-xD Drish-xD marked this pull request as ready for review July 29, 2024 19:19
@Drish-xD
Copy link
Collaborator Author

left a comment.. do write a description of PR

  • do we also "gray" the row to indicate pending status ? or no need? up to you

Faded the row is its status is pending.

@Drish-xD Drish-xD changed the title Feature/polling [36] – Feature: Polling Aug 5, 2024
@Drish-xD Drish-xD merged commit 6bf4b83 into main Aug 6, 2024
1 check passed
@Drish-xD Drish-xD deleted the feature/polling branch August 6, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Polling Need to be Implemented
2 participants