Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI-Changes #34

Merged
merged 6 commits into from
Mar 7, 2024
Merged

UI-Changes #34

merged 6 commits into from
Mar 7, 2024

Conversation

Prakhar-commits
Copy link
Contributor

@Prakhar-commits Prakhar-commits commented Mar 2, 2024 •
edited
Loading

Summary

This PR majorly focuses on combining both the tables in quiz-creator and miscellaneous UI changes

  • Test Responsiveness
    • Laptop (1200px)
    • Tablet (760px)
    • Phone (320px)
  • Cross-Browser Testing
    • Chrome
    • Firefox
  • Local Language Support
  • Hygiene and Housekeeping
    • Self-review
    • Comments have been added appropriately
    • Check for bundle size here if adding a package
    • Added relevant details like Labels/Projects/Milestones etc.
    • If adding or removing any environment variable, update docs/ENV.md, .env.example and the Github workflows.
  • Testing
    • Wrote tests
    • Tested locally
    • Tested on staging
    • Tested on an actual physical phone
    • Tested on production
  • Lighthouse Checks
    • Images have alt attributes
    • Any <img> tags have width and height specified
    • Any target="_blank" links have rel="noopener"
    • Only SVGs are used as images. If PNGs are used, their size has been optimised.
    • Any SVG buttons without text have their aria-label attributes set

suryabulusu
suryabulusu reviewed Mar 7, 2024
View reviewed changes
Copy link
Contributor

@suryabulusu suryabulusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few ui usses
(1) why copy edit button ke neeche line is weird
(2) gap between box name and box
(3) timings in home page

https://uichanges.dauyvuo7dvzau.amplifyapp.com/?pageNo=0 link

src/utils/FormInputHandling.ts Outdated
@@ -15,34 +14,14 @@ async function getData(currentPage: number, limit: number) {
});
const hasMore = data.length > limit;
const items = hasMore ? data.slice(0, -1) : data;
console.log(data);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

@suryabulusu suryabulusu merged commit 4a48579 into main Mar 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suryabulusu suryabulusu suryabulusu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Prakhar-commits @suryabulusu