Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plio items in plio response #238

Merged
merged 2 commits into from
Sep 7, 2021
Merged

Plio items in plio response #238

merged 2 commits into from
Sep 7, 2021

Conversation

rathorevaibhav
Copy link
Contributor

@rathorevaibhav rathorevaibhav commented Sep 1, 2021

Targets #232

Summary

  1. Sending items data when plio is fetched. This will help to reduce a separate call to fetch plio items.

Silk query data with single plio query that also includes items:
image

Test Plan

  • Wrote tests
  • Tested locally
  • Tested on staging
  • Tested on production
  • If changes in DB, update DB schema and BigQuery (staging and prod)

@rathorevaibhav rathorevaibhav changed the title querying items when plio play view is called Plio items in plio response Sep 1, 2021
@codecov
Copy link

codecov bot commented Sep 1, 2021

Codecov Report

Merging #238 (cfa8991) into master (9dad468) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #238   +/-   ##
=======================================
  Coverage   95.91%   95.91%           
=======================================
  Files         123      123           
  Lines        2399     2400    +1     
=======================================
+ Hits         2301     2302    +1     
  Misses         98       98           
Impacted Files Coverage Δ
plio/serializers.py 97.77% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dad468...cfa8991. Read the comment docs.

@rathorevaibhav rathorevaibhav self-assigned this Sep 1, 2021
@dalmia dalmia merged commit 38e0f93 into master Sep 7, 2021
@dalmia dalmia deleted the feature/232-plio-play-items branch September 7, 2021 21:41
@dalmia dalmia added this to the v0.3.2 milestone Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants