Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add current section to playlist #6215

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

masaball
Copy link
Contributor

@masaball masaball commented Mar 3, 2025

Related issue: #6209

Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this out locally but I wasn't seeing a change in behavior but maybe I was testing it incorrectly or expecting behavior that is different than how it works.

Steps I took:

  1. Create an item and upload 2 files
  2. Edit the structure for the first file and add two divs with two spans under each div
  3. On the view page select the first span under the first div
  4. Click Add to playlist, select current section (Name of first div), and click Add
  5. Go to playlist and see that all four spans have been added to the playlist (instead of the two under the first div)

Digging a little deeper maybe this is an issue with just the label displayed in the modal. I'm wondering if getTimelineScopes() is marking the wrong structure node as current-section. Maybe the HTML of the structure changed in ramp and that method didn't get updated? That's a guess.

@masaball
Copy link
Contributor Author

masaball commented Mar 4, 2025

Looking back at the ticket, I may have had too simple a structure on my test item as I'm not sure I had multiple divs.

Regardless, I was interpreting the current section option to be for adding an entire masterfile and then for adding just a subset of divs or spans you would use the current track option. If I have that behavior right, seeing all four spans in the playlist would be the expected behavior. So it would be that the modal just has the current-section label wrong. I'll take another look tomorrow at getting that populated properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants