Node and webpack upgrade using shakapacker #5308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
cjcolvar
force-pushed
the
node_webpack_upgrade
branch
from
4f57aef
to
710d56a
Compare
|
I had to do a |
|
I tested Collections, Timeliner, SME, and some other generic JS code. It all worked well expect for uploading a collection poster image giving me the error 'There was a problem storing the poster image.', which works in I faced a similar issue with Ramp we saw on avalon-dev where it cannot find the component on item page. |
|
Testing locally, I didn't have that issue with uploading a poster, but I did see that same error with Ramp. I think I fixed the underlying issue and was able to get Ramp to not throw that error, but it still wasn't loading for me because I think the item I was testing with was bad. |
Dananji
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5304
Webpacker has been deprecated in favor of other approaches to JS in Rails 7. Shakapacker is a continuation of webpacker that has support for webpack 5. The switch to webpack 5 also required explicitly including polyfills. This successfully compiles assets, but I haven't tried seeing if everything is actually working in a browser.