update to new power-assert-runtime

[nfcampos]

• should close Feature Request: Better error messaging for acorn parsing errors when testing React #693, ES Bind Operator Throws SyntaxError When Test Failing #881 and similar issues about experimental syntax breaking on assertion failure.
• it also appears to be faster than before, but not by much
• i've added two tests that assert that using JSX and {...o} on an assertion works

maybe @twada can check whether I correctly configured the various power-assert things

[twada]

Thanks @nfcampos! This is exactly what I wanted to do today 😃

babel-plugin-espower 2.2.0 and the new power-assert-runtime comes with many architectural improvements with less dependencies. I hope AVA guys will like it.

[jamestalmage]

I'm sure we will!

@twada, has the runtime dependency graph been reduced? Should we move rendering back into the child processes - we've had lots of problems trying to serialize large objects for rendering in the main thread.

[twada]

has the runtime dependency graph been reduced?

Yeah, reducing dependencies is one of the goals of new power-assert-runtime. There's no extra parser anymore. Many ponyfills are consolidated into single core-js.

I also recommend @nfcampos to update empower-core to 0.6.1 to reduce dependencies much more.

Should we move rendering back into the child processes

Yes. Now we can render power-assert output in subprocesses.

[jamestalmage]

@nfcampos. Can you bump the dependency as mentioned? Otherwise this looks good to me.

We can tackle moving rendering to the child process in another PR

[nfcampos]

done

[twada]

Thanks @nfcampos, looks good to me! 👍

[jamestalmage]

Thanks @nfcampos! Want to work on moving the renderer into the child process?

The idea is to go back to the way power-assert behaves in other contexts - replacing the message on the error.

[nfcampos]

@jamestalmage yes, I'll do that, if I understand correctly it's something like using https://github.com/power-assert-js/empower instead of empower-core in enhance-assert.js and stop using the formatter in run-status.js?

[twada]

@nfcampos One thing to notice is that empower module is now a thin wrapper around empower-core for power-assert internal compatibility and there is no reason to use empower in AVA. It's better to keep using empower-core directly.

[nfcampos]

@twada yeah you're right

[jimthedev]

@nfcampos So, quick question about the ava docs and this PR, specifically in the React recipe for JSX helpers there the following note:

Note that you have to use variables like actual and expected because power-assert doesn't handle JSX correctly.

The text links to this issue which although open (documentation still pending) states that it will be available in ava as soon as this PR (#903) is merged. Since #903 has been merged, do we need to remove that note from the React recipe?

[nfcampos]

yes that note should be removed, that should now work