detect improper use of t.throws

[jamestalmage]

Protects against a common misuse of t.throws (Like that seen in #739).

This required the creation of a custom babel plugin.

https://github.com/jamestalmage/babel-plugin-ava-throws-helper

Sample output:

Improper usage of t.throws detected at /Users/jamestalmage/dev/ava/test/fixture/improper-t-throws.js (4:10).

You should wrap the following expression in a function:

  throwSync()

Like this:

  function() {
    throwSync()
  }

See https://github.com/sindresorhus/ava#throwsfunctionpromise-error-message for more details.

The linked documentation isn't that helpful. We should probably make a short recipe about this. (maybe a common-mistakes recipe? This seems like too small a topic for a whole recipe). We can update the URL when that recipe is written.

[mention-bot]

By analyzing the blame information on this pull request, we identified @spudly, @ariporad and @ingro to be potential reviewers

[novemberborn]

Promote arrow functions?

[jamestalmage]

I considered that.

But if the user is green enough that that they don't fully understand how throw works, I was concerned about piling on another abstraction they need to understand.

[novemberborn]

Yea fair enough.

[novemberborn]

The linked documentation isn't that helpful. We should probably make a short recipe about this

👍

(maybe a common-mistakes recipe?

#404?

[vadimdemedes]

/Users/jamestalmage/dev/ava/test/fixture/improper-t-throws.js (4:10)

Perhaps displaying relative path would be better and would align with our "clean stack traces" feature.

[jamestalmage]

Updated with relative file paths and colors:

[vadimdemedes]

I know it is an overkill, but would be incredibly cool to have syntax highlight in errors (not just this one).

[jamestalmage]

I know it is an overkill, but would be incredibly cool to have syntax highlight in errors (not just this one).

Like this?:

[jamestalmage]

I think maybe the middle section:

The following expression:
  t.throws()

Is kinda useless with the codeframe right above.

[jamestalmage]

[vadimdemedes]

Super awesome!

[sindresorhus]

Marvelous.

[novemberborn]

Cool!

Should update the default plugin sections in the readme and babelrc recipe.

[jamestalmage]

Should update the default plugin sections in the readme and babelrc recipe.

I went with just the babelrc recipe. I feel like most user's don't care, so I don't want to pollute the readme with every side-effect free plugin we install. Really, we could just update the readme to say. "AVA always includes a few internal plugins regardless of configuration, but they should not impact the behavior of hour code", and then link to the Notes section of the babelrc recipe.

[sindresorhus]

"AVA always includes a few internal plugins regardless of configuration, but they should not impact the behavior of hour code", and then link to the Notes section of the babelrc recipe.

👍

[jfmengels]

🎉

[sindresorhus]

🍾✨