Skip to content

Manage assertions through a class #2080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Apr 22, 2019
Merged

Manage assertions through a class #2080

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
a946746
Refactor assertions to be a class
qlonik Mar 24, 2019
b495373
Mark enhanceAssert() for deletion
qlonik Mar 24, 2019
b27e0e9
Do not rely on passed arguments length in validateExpectations()
qlonik Mar 24, 2019
977080b
Add comments describing changes
qlonik Mar 24, 2019
ce49d53
Add regression tests for #1676
qlonik Mar 31, 2019
9061a08
Retain functionality passing number of args as #1676 fix
qlonik Mar 31, 2019
4efe9d5
Add comment explaining usage of ...args in .throws()
qlonik Mar 31, 2019
63c8ffc
Hide private methods by not assigning them to instance
qlonik Apr 1, 2019
9e22fd2
Adjust how we extends Assertions class
qlonik Apr 1, 2019
1ef541f
Remove unneeded try-catch in .throws() assertion
qlonik Apr 1, 2019
7adec90
Fix typo which should have failed the test
qlonik Apr 1, 2019
086c339
Style change by xo
qlonik Apr 1, 2019
1761c26
Separate test lines to make sure each of them passes
qlonik Apr 1, 2019
b74519d
Adjust style with xo
qlonik Apr 1, 2019
a752a75
Remove unneeded enhanceAssert() and move comment about PATTERNS
qlonik Apr 1, 2019
d6d89ec
Remove unneeded jsdoc comments
qlonik Apr 6, 2019
261b59c
Check that all assertions are properly bound
qlonik Apr 6, 2019
270e9b1
Check that snapshot assertion is properly bound
qlonik Apr 6, 2019
8451f20
Remove unneeded comment
qlonik Apr 6, 2019
acb27a0
Check that ExecutionContext functions are bound
qlonik Apr 6, 2019
7dde150
Ensure fns on ExecutionContext are bound to it
qlonik Apr 6, 2019
245c222
Final tweaks
novemberborn Apr 19, 2019
3ce1b9c
Merge branch 'master' into refactor-assert
novemberborn Apr 20, 2019
dd8def8
Fix bad merge
novemberborn Apr 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading