fork.js: Reject child-process completion promise with an error. #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is generally recommended to reject Promises with an error. This becomes especially true with the move to `async/await`, as `Promise.reject(1)` essentially becomes `throw 1` in that context. Not doing so was causing a weird bug on Node 0.10.
Closed
|
Agreed. Rejecting without an error makes it impossible to see where it happened. |
|
Fails on Node 0.10 :/ https://ci.appveyor.com/project/sindresorhus/ava/build/96/job/3yun8im3pcpp3o8w |
|
Passes on Windows 7 / Node 10 here. Give me a moment. to get those logged in the tracking issue. |
sindresorhus
added a commit
that referenced
this pull request
Nov 12, 2015
fork.js: Reject child-process completion promise with an error.
|
Alright |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is generally recommended to reject Promises with an error.
This becomes especially true with the move to
async/await,as
Promise.reject(1)essentially becomesthrow 1in that context.Not doing so was causing a weird bug on Node 0.10.
Ref: https://travis-ci.org/sindresorhus/ava/jobs/90709377#L779