Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure assertion message is a string #1831

Closed
wants to merge 1 commit into from
Closed

Ensure assertion message is a string #1831

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/assert.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@ const hasOwnProperty = (obj, prop) => Object.prototype.hasOwnProperty.call(obj,

class AssertionError extends Error {
constructor(opts) {
if (opts.message !== undefined && typeof opts.message !== 'string') {
throw new TypeError('Assertion message must be a string');
}
super(opts.message || '');
this.name = 'AssertionError';

Expand Down
8 changes: 8 additions & 0 deletions test/assert.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,14 @@ function eventuallyPasses(t, fn) {
});
}

test('AssertionError throws when message is not a string', t => {
const input = new Error('an error object');
const AssertionError = assert.AssertionError;
const expectedError = new TypeError('Assertion message must be a string');
t.throws(() => new AssertionError({message: input}), expectedError);
t.end();
});

test('.pass()', t => {
passes(t, () => {
assertions.pass();
Expand Down