Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify custom adapters #280

Merged
merged 5 commits into from
Aug 5, 2024
Merged

Simplify custom adapters #280

merged 5 commits into from
Aug 5, 2024

Conversation

SentryMan
Copy link
Collaborator

@SentryMan SentryMan commented Aug 3, 2024 •
edited
Loading

  • No longer requires an isGeneric value in the annotation
  • allow non-generic adapters to register with a default constructor
  • add a new method to register a supplier of an adapter

@SentryMan SentryMan added the enhancement New feature or request label Aug 3, 2024
@SentryMan SentryMan added this to the 2.1 milestone Aug 3, 2024
@SentryMan SentryMan self-assigned this Aug 3, 2024
@SentryMan SentryMan requested a review from rbygrave August 3, 2024 14:41
@SentryMan SentryMan changed the title Simplify generic custom adapters Simplify custom adapters Aug 3, 2024
@rbygrave rbygrave merged commit f46f7bc into avaje:main Aug 5, 2024
5 checks passed
@SentryMan SentryMan deleted the custom branch August 5, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbygrave rbygrave Awaiting requested review from rbygrave

Assignees

@SentryMan SentryMan

Labels
enhancement New feature or request
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@SentryMan @rbygrave