Skip to content

[Jex-Generator] Handle Jex Exceptions #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SentryMan merged 2 commits into from
Dec 3, 2024
Merged

[Jex-Generator] Handle Jex Exceptions #527

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b587f1
handle jex exceptions
SentryMan Dec 2, 2024
8a83170
Merge branch 'master' into jex-exception
rbygrave Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions http-generator-jex/src/main/java/io/avaje/http/generator/jex/ControllerMethodWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,9 +158,9 @@ void writeHandler(boolean requestScoped) {
if (method.isErrorMethod()) {
writer.append(" private void _%s(Context ctx, %s ex) {", method.simpleName(), method.exceptionShortName());
} else if (isFilter) {
writer.append(" private void _%s(Context ctx, FilterChain chain) throws IOException {", method.simpleName());
writer.append(" private void _%s(Context ctx, FilterChain chain) throws Exception {", method.simpleName());
} else {
writer.append(" private void _%s(Context ctx) throws IOException {", method.simpleName());
writer.append(" private void _%s(Context ctx) throws Exception {", method.simpleName());
}

writer.eol();
Expand Down
2 changes: 1 addition & 1 deletion tests/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<junit.version>5.11.3</junit.version>
<assertj.version>3.26.3</assertj.version>
<jackson.version>2.18.2</jackson.version>
<jex.version>3.0-RC7</jex.version>
<jex.version>3.0-RC8</jex.version>
<avaje-inject.version>11.0</avaje-inject.version>
<nima.version>4.1.4</nima.version>
<javalin.version>6.3.0</javalin.version>
Expand Down
3 changes: 1 addition & 2 deletions tests/test-jex/src/main/java/org/example/web/TestController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package org.example.web;

import java.io.IOException;
import java.util.Set;

import io.avaje.http.api.BodyString;
Expand Down Expand Up @@ -47,7 +46,7 @@ String strBody(@BodyString String body, Context ctx) {
}

@Filter
void filter(FilterChain chain) throws IOException {
void filter(FilterChain chain) throws Exception {
System.err.println("do nothing lmao");
chain.proceed();
}
Expand Down