[http-client] Make clients AutoCloseable#512
Merged
Merged
Conversation
SentryMan
force-pushed
the
auto-close
branch
from
7b437f1 to
18c5920
Compare
Contributor
Yes, I reckon we should. Nice spotting and nice work. |
rbygrave
approved these changes
Nov 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since JDK 21,
java.net.HttpClientnow extendsAutoCloseable, should we not follow suit?io.avaje.http.client.HttpClientnow extendsAutoCloseable(has no effect unless on 21 or higher)