-
Notifications
You must be signed in to change notification settings - Fork 18
[http-client] Fix BeanParam on Eclipse #436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
...generator-client/src/test/java/io/avaje/http/generator/client/clients/ExampleClient2.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,15 @@ | ||
| package io.avaje.http.generator.client.clients; | ||
|
|
||
| import io.avaje.http.api.BeanParam; | ||
| import io.avaje.http.api.Client; | ||
| import io.avaje.http.api.Patch; | ||
| import io.avaje.http.api.Post; | ||
|
|
||
| @Client | ||
| public interface ExampleClient2 extends ExampleClient { | ||
| @Patch | ||
| void patchy2(); | ||
|
|
||
| @Post | ||
| void beanParam(@BeanParam Params s); | ||
| } |
49 changes: 49 additions & 0 deletions
49
http-generator-client/src/test/java/io/avaje/http/generator/client/clients/Params.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| package io.avaje.http.generator.client.clients; | ||
|
|
||
| import io.avaje.http.api.Cookie; | ||
| import io.avaje.http.api.Header; | ||
| import io.avaje.http.api.QueryParam; | ||
|
|
||
| public class Params { | ||
|
|
||
| public String param; | ||
|
|
||
| @QueryParam("named") | ||
| private String param2; | ||
|
|
||
| @Header private String head; | ||
| @Cookie private String cook; | ||
| public String publicQuery; | ||
|
|
||
| public String getParam() { | ||
| return param; | ||
| } | ||
|
|
||
| public void setParam(String param) { | ||
| this.param = param; | ||
| } | ||
|
|
||
| public String getParam2() { | ||
| return param2; | ||
| } | ||
|
|
||
| public void setParam2(String param2) { | ||
| this.param2 = param2; | ||
| } | ||
|
|
||
| public String getHead() { | ||
| return head; | ||
| } | ||
|
|
||
| public void setHead(String head) { | ||
| this.head = head; | ||
| } | ||
|
|
||
| public String getCook() { | ||
| return cook; | ||
| } | ||
|
|
||
| public void setCook(String cook) { | ||
| this.cook = cook; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not add anything to the test coverage?
We have
@BeanParamsin tests/test-client-generation in JunkApi and CommonParams and if we needed more coverage we would add it there?I'll remove this I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps so, but these generator tests are what allow me to properly debug the processor with my IDE.