Reduce ABI Gen diff

[michaelkaplan13]

Inlines the ABI generation so that the existing files remain, and keeps the pretty-json formatting.

Also removes the metadata hashes from the bytecode of the compiles test contracts, so that it prevents unnecessary diffs in the future.

[michaelkaplan13]

The resulting combined diff is best viewed by having this PR be based on the JonathanOppenheimer/delete-npm branch.

[JonathanOppenheimer]

I like these changes -- the pretty print is a nice addition, and it makes reading the generated files easier for a human too.

Are you good if I merge this and then add a commit in the main branch to get rid of your renaming change? I think a whole bunch of contract.abis is unclear, and git should be able to show the move properly as a rename now anyway (so it'll be easy to review), and two files won't be shown, even if we rename allowlist.abi -> IAllowList.abi

[michaelkaplan13]

I like these changes -- the pretty print is a nice addition, and it makes reading the generated files easier for a human too.

Are you good if I merge this and then add a commit in the main branch to get rid of your renaming change? I think a whole bunch of contract.abis is unclear, and git should be able to show the move properly as a rename now anyway (so it'll be easy to review), and two files won't be shown, even if we rename allowlist.abi -> IAllowList.abi

Definitely feel free to merge into your branch whenever. I think renaming the contract.abi files is best left for a separate PR though. It's not required, and it's best to be a standalone trivial PR in the future as Arran suggested.

[JonathanOppenheimer]

Sounds good - I can do that in the future PR.