PARTIAL sync: coreth PR #1252: align ci files format #1792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanOppenheimer
requested review from
a team,
alarso16 and
maru-ava
as code owners
JonathanOppenheimer
force-pushed
the
align-ci
branch
from
da119d2 to
8f3bdeb
Compare
JonathanOppenheimer
changed the title
Member
Author
|
@maru-ava, I want to confirm the other changes in your original coreth PR do not apply here, correct? |
maru-ava
approved these changes
Oct 9, 2025
Contributor
I suggest removing setup-go from the jobs that use run-monitored-tmpnet-cmd since it provides the correct golang version via the avalanchego nix shell. |
alarso16
approved these changes
Oct 9, 2025
Member
Author
Gotcha! |
JonathanOppenheimer
force-pushed
the
align-ci
branch
from
d1058a6 to
0dd4f99
Compare
maru-ava
approved these changes
Oct 10, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
powerslider
approved these changes
Oct 10, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
I was looking to sync a coreth PR, and made minor changes here to bring the CI in closer alignment with each other. This is a pretty nit picky PR. The PR I partially synced here is ava-labs/coreth#1252