Skip to content

Conversation

@darioush
Copy link

Why this should be merged

Takes code from upstream

How this works

Takes code from upstream

How this was tested

[ ] CI
[ ] testnet

How is this documented

N/A

ceyonur
ceyonur previously approved these changes Aug 30, 2024
Copy link
Collaborator

@ceyonur ceyonur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ceyonur ceyonur enabled auto-merge (squash) September 2, 2024 10:58
ceyonur
ceyonur previously approved these changes Sep 2, 2024
@ARR4N ARR4N disabled auto-merge September 2, 2024 11:23
ARR4N
ARR4N previously approved these changes Sep 2, 2024
Copy link
Contributor

@ARR4N ARR4N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for @ceyonur's latest push, which negates his approval

* avoid modifying the pointer

* improve readability

* prevent race in tail reading

* improve repairTxIndexTail readability

* use shared func
@ceyonur ceyonur dismissed stale reviews from ARR4N and themself via e407ce4 September 2, 2024 14:32
@ceyonur ceyonur enabled auto-merge (squash) September 2, 2024 14:33
@ceyonur ceyonur disabled auto-merge September 2, 2024 14:55
@ceyonur
Copy link
Collaborator

ceyonur commented Sep 2, 2024

Force-Merging it since we merged an already approved PR

@ceyonur ceyonur merged commit a929cb3 into master Sep 2, 2024
@ceyonur ceyonur deleted the geth-v1.13.14-sq branch September 2, 2024 14:56
@darioush darioush restored the geth-v1.13.14-sq branch September 4, 2024 19:54
JonathanOppenheimer pushed a commit that referenced this pull request Sep 2, 2025
Signed-off-by: Stephen Buttolph <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants