Misc Ports from #136 and #159 #171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Not shutting down properly (seem to be missing messages somewhere): |
Contributor
Author
|
If same conn submits a duplicate tx, we will now only send 1 message back. |
patrick-ogrady
commented
May 11, 2023
| ContinuousProfilerDir string `json:"continuousProfilerDir"` // "*" is replaced with rand int | ||
|
|
||
| // Streaming Ports | ||
| StreamingPort uint16 `json:"streamingPort"` |
Contributor
Author
There was a problem hiding this comment.
Should've been removed in WS port PR
patrick-ogrady
commented
May 11, 2023
|
|
||
| type WebSocketClient struct { | ||
| conn *websocket.Conn | ||
| wl sync.Mutex |
Contributor
Author
There was a problem hiding this comment.
Fixed a panic found in testing
patrick-ogrady
commented
May 11, 2023
| PongWait = 60 * time.Second | ||
| PingPeriod = (PongWait * 9) / 10 | ||
| MaxMessageSize = 10 * units.KiB // bytes | ||
| MaxMessageSize = consts.NetworkSizeLimit |
Contributor
Author
There was a problem hiding this comment.
Ensured can submit full txs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #136
Related: #159