This repository was archived by the owner on Nov 25, 2025. It is now read-only.
Add comments for context for future precompile addition#990
Merged
Conversation
ceyonur
approved these changes
May 28, 2025
maru-ava
approved these changes
May 28, 2025
Contributor
maru-ava
left a comment
maru-ava
left a comment
There was a problem hiding this comment.
LGTM modulo figuring out why this is failing e2e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this should be merged
ACP-204 proposes adding a new precompile to coreth. Added comments to this file for clarity in case of future implementation. Lists the address of warp precompile in
registry.goHow this works
all changes are non-functional
How this was tested
NA
Need to be documented?
No
Need to update RELEASES.md?
No