Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove currentStateLock #741

Merged
merged 1 commit into from
Jan 9, 2025
Merged

remove currentStateLock #741

merged 1 commit into from
Jan 9, 2025

Conversation

darioush
Copy link
Collaborator

@darioush darioush commented Jan 9, 2025

Why this should be merged

This lock is not present in upstream and we hold pool.mu in all cases this lock is held so it's not providing any additional guarantees.

How this works

Removes code

How this was tested

CI

Need to be documented?

N/A

Need to update RELEASES.md?

N/A

@darioush darioush marked this pull request as ready for review January 9, 2025 15:15
@darioush darioush requested review from ceyonur and a team as code owners January 9, 2025 15:15
@darioush darioush changed the title attempt to remove currentStateLock remove currentStateLock Jan 9, 2025
Copy link
Collaborator

@qdm12 qdm12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe that's totally paranoid, but given the Init method on the LegacyPool does assign currentState, shall we add pool.mu.Lock() and unlock in that function, just in case ™️ Or not, if it's a copy pasta from geth 🤷

@ceyonur ceyonur merged commit 24e1459 into master Jan 9, 2025
8 checks passed
@ceyonur ceyonur deleted the remove-currentStateLock branch January 9, 2025 18:13
qdm12 pushed a commit that referenced this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants