verify single predicate (#960) #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* verify single predicate * simplify returned error * track indexes for predicates * don't short cirtcuit predicate err * Update predicate_check.go Signed-off-by: Ceyhun Onur <[email protected]> * nits for single-predicate-verify (#1012) * Update x/warp/predicate_test.go Co-authored-by: aaronbuchwald <[email protected]> Signed-off-by: Ceyhun Onur <[email protected]> * Update x/warp/predicate_test.go Co-authored-by: aaronbuchwald <[email protected]> Signed-off-by: Ceyhun Onur <[email protected]> * review fixes * use bitset constructor * change return type to err in verifypredicate --------- Signed-off-by: Ceyhun Onur <[email protected]> Signed-off-by: Ceyhun Onur <[email protected]> Co-authored-by: marun <[email protected]> Co-authored-by: Darioush Jalali <[email protected]> Co-authored-by: aaronbuchwald <[email protected]>
aaronbuchwald
approved these changes
Jan 2, 2024
darioush
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrors: ava-labs/subnet-evm#960