speedup jailbreak monkey (-700ms) #3289
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Szymon20000
requested review from
B0Y3R-AVA,
atn4z7,
bogdandobritoiu,
onghwan and
ruijialin-avalabs
as code owners
atn4z7
reviewed
Oct 15, 2025
| - check = new GreaterThan23(); | ||
| - } else { | ||
| - check = new LessThan23(); | ||
| + Trace.beginSection("[JailMonkey] checkWithJailMonkeyMethod"); |
There was a problem hiding this comment.
is all this tracing logic still needed?
atn4z7
reviewed
Oct 15, 2025
| diff --git a/android/src/main/java/com/gantix/JailMonkey/JailMonkeyModule.java b/android/src/main/java/com/gantix/JailMonkey/JailMonkeyModule.java | ||
| index 018d7051a57a2250c738e018ba8e1518d1b9525a..e89a135c10edc50174315c5cf0a3c9871fe65e6a 100644 | ||
| --- a/android/src/main/java/com/gantix/JailMonkey/JailMonkeyModule.java | ||
| +++ b/android/src/main/java/com/gantix/JailMonkey/JailMonkeyModule.java |
There was a problem hiding this comment.
could you also drop a quick comment in packages/core-mobile/docs/patches.md about this patch?
Signed-off-by: Szymon Kapała <[email protected]>
Added a note about precomputing constants for jail-monkey checks. Signed-off-by: Szymon Kapała <[email protected]>
Signed-off-by: Szymon Kapała <[email protected]>
atn4z7
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Jailmonkey by default computes constants when we need them. The problem is that some operations it does are super slow. So instead we check if phone is rooted on background thread and return the answer right away without blocking anything.
Ticket: [CP-]
Please provide:
Screenshots/Videos
Include relevant screenshots or screen recordings of iOS and Android.
Testing
Dev Testing (if applicable)
QA Testing (if applicable)
Checklist
Please check all that apply (if applicable)