feat(ng): ledger BTC wallet policies #476
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frichards
reviewed
Nov 3, 2025
| contentProps?: StackProps; | ||
| containerProps?: StackProps; | ||
| withViewSwitcher?: boolean; | ||
| titleProps?: TypographyProps; |
There was a problem hiding this comment.
titleProps seems like it is not getting used in the Page component. Do we need this one still?
|
|
||
| const Content = ComponentByPhase[phase]; | ||
|
|
||
| console.log('DEBUG status', status, policyName); |
There was a problem hiding this comment.
We not only can, we need to :D Thanks!
| setStatus('idle'); | ||
| reset(); | ||
|
|
||
| if (status.endsWith(':error')) { |
There was a problem hiding this comment.
Since we set the status to be idle on line 33 and reset does not seem to update status, will this be ever true?
There was a problem hiding this comment.
Oh, I see how this can be confusing.
setStatus (like all state setters) is async, meaning that status on line 36 is the same as it was before setStatus on line 33 was called.
I'll rearrange it a bit to make it less confusing :)
There was a problem hiding this comment.
Ah! This change now makes sense! Thank you for updating this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Testing
Screenshots:
Ledger.-.BTC.policy.mov
Checklist for the author