Skip to content

fix: domain whitelist #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2025
Merged

fix: domain whitelist #472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions packages/common/src/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,28 @@ const SYNCED_DOMAINS_DEVELOPMENT_BUILD = [
...DAPP_DEV_DOMAINS,
] as const;

const KNOWN_AVACLOUD_DOMAINS = [
'avacloud.io',
'avacloud-app.pages.dev',
'launchpad.avacloud.io',
];

const PLAYGROUD_APP = 'ava-labs.github.io';

export const KNOWN_CORE_DOMAINS = [
CORE_WEB_DOMAIN,
...CORE_WEB_STAGING_DOMAINS,
...DAPP_DEV_DOMAINS,
] as const;

// Domains allowed to access the avalanche_* methods
export const WHITELISTED_DOMAINS = [
...KNOWN_CORE_DOMAINS,
...KNOWN_AVACLOUD_DOMAINS,
...DAPP_DEV_DOMAINS,
PLAYGROUD_APP,
];

export const SYNCED_DOMAINS = isProductionBuild()
? SYNCED_DOMAINS_PRODUCTION_BUILD
: SYNCED_DOMAINS_DEVELOPMENT_BUILD;
Expand Down
6 changes: 3 additions & 3 deletions packages/service-worker/src/connections/middlewares/PermissionMiddleware.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import { AccountsService } from '../../services/accounts/AccountsService';
import { LockService } from '../../services/lock/LockService';
import { PermissionsService } from '../../services/permissions/PermissionsService';
import {
CORE_DOMAINS,
ExtensionConnectionMessage,
ExtensionConnectionMessageResponse,
DAppProviderRequest,
Expand All @@ -11,6 +10,7 @@ import {
} from '@core/types';
import { Middleware } from './models';
import { RpcMethod } from '@avalabs/vm-module-types';
import { WHITELISTED_DOMAINS } from '@core/common';

const RESTRICTED_METHODS = Object.freeze([] as string[]);

Expand Down Expand Up @@ -164,8 +164,8 @@ export function PermissionMiddleware(

if (
context.authenticated === true &&
(CORE_DOMAINS.includes(domain) ||
CORE_DOMAINS.includes(domainWithoutSubdomain.join('.')))
(WHITELISTED_DOMAINS.includes(domain) ||
WHITELISTED_DOMAINS.includes(domainWithoutSubdomain.join('.')))
) {
next();
} else {
Expand Down
14 changes: 0 additions & 14 deletions packages/types/src/ui-connection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,20 +334,6 @@ export interface JSONRPCRequestWithDomain extends JsonRpcRequest<any> {
domain: string;
}

export const CORE_DOMAINS = [
'localhost',
'127.0.0.1',
'core-web.pages.dev',
'core.app',
'staging.core.app',
'develop.core.app',
'ava-labs.github.io', // playground
'avacloud.io',
'avacloud-app.pages.dev',
'launch-4zn.pages.dev',
'launchpad.avacloud.io ',
];

export interface ConnectionController {
connect(connection: Runtime.Port): void;
disconnect(): void;
Expand Down
Loading