Add signature collection logs #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cam-schultz
requested review from
michaelkaplan13,
minghinmatthewlam,
geoff-vball and
bernard-avalabs
as code owners
geoff-vball
approved these changes
Jun 14, 2024
michaelkaplan13
approved these changes
Jun 14, 2024
Comment on lines
+322
to
+324
| zap.String("warpMessageID", unsignedMessage.ID().String()), | ||
| zap.String("sourceBlockchainID", r.sourceBlockchain.GetBlockchainID().String()), | ||
| zap.String("destinationBlockchainID", r.relayerID.DestinationBlockchainID.String()), |
There was a problem hiding this comment.
Not necessary in this PR, but could be cleaner to have some logging helpers for repeated variables (such as "warpMessageID") to avoid the string literals in so many places.
There was a problem hiding this comment.
I've thought about this some, but haven't found any satisfying solution. Helpers would reduce repitition in the code, but aren't the most extensible or generic. A decorator-type extension to logger.Logger that always logs certain fields and still takes additional arguments would be ideal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Adds additional logs in the signature collection code to aid debugging.
How this works
How this was tested
How is this documented