Skip to content

Commit

Permalink
hack versions.sh to hardcode subnet-evm's branch
Browse files Browse the repository at this point in the history
because the go.mod version string is assumed to be a github ref, eg to be
checked out during CI's e2e workflow, but currently we're using a reference
that was created by using `go get` with a branch name, which resolves to a
pseudo version in the go.mod file, which doesn't refer to any git ref in the
subnet-evm repo.
  • Loading branch information
feuGeneA committed Jul 19, 2024
1 parent 64b0de8 commit 7040026
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion scripts/versions.sh
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,10 @@ export GO_VERSION=${GO_VERSION:-$(getDepVersion go)}
# Don't export them as they're used in the context of other calls
AVALANCHEGO_VERSION=${AVALANCHEGO_VERSION:-$(getDepVersion github.com/ava-labs/avalanchego)}
GINKGO_VERSION=${GINKGO_VERSION:-$(getDepVersion github.com/onsi/ginkgo/v2)}
SUBNET_EVM_VERSION=${SUBNET_EVM_VERSION:-$(getDepVersion github.com/ava-labs/subnet-evm)}

# TODO: undo this hack once go.mod is referring to a tag rather than a commit
#SUBNET_EVM_VERSION=${SUBNET_EVM_VERSION:-$(getDepVersion github.com/ava-labs/subnet-evm)}
SUBNET_EVM_VERSION=${SUBNET_EVM_VERSION:-update-avago-teleporter}

# Set golangci-lint version
GOLANGCI_LINT_VERSION=${GOLANGCI_LINT_VERSION:-'v1.55'}

0 comments on commit 7040026

Please sign in to comment.