Separate warp storage and message verification#5199
Merged
StephenButtolph merged 6 commits intoceyonur/sae-warpfrom Apr 8, 2026
Merged
Separate warp storage and message verification#5199StephenButtolph merged 6 commits intoceyonur/sae-warpfrom
StephenButtolph merged 6 commits intoceyonur/sae-warpfrom
Conversation
StephenButtolph
commented
Apr 7, 2026
Contributor
Author
StephenButtolph
left a comment
There was a problem hiding this comment.
Sorry... The diff is super annoying to review because of the renames:
warp/backend/backend.go->warp/storage.gowarp/backend/backend_test.go->warp/storage_test.gowarp/backend/verifier_backend.go->warp/verifier.gowarp/backend/verifier_backend_test.go->warp/verifier_test.go
ceyonur
reviewed
Apr 8, 2026
ceyonur
approved these changes
Apr 8, 2026
Contributor
ceyonur
left a comment
There was a problem hiding this comment.
left a small comment regarding to preserve the caching, otherwise lgtm.
ceyonur
reviewed
Apr 8, 2026
ceyonur
reviewed
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behavioral changes
Hashmessages. It isn't clear to me why this restriction existed.NewCachedHandlerfunction.Cleanup
Backendtype, it is handled by theConfignowBackendtype, it is handled by theacp.118.HandlerBackendinto 2 types,StorageandVerifier.VerifierlogicStorageandVerifier.warp/backendpackage into thewarppackage.Other
I also just removed the log from
Backend.AddMessage, we could provide the logger to theStorage... But I felt like it wasn't worth it... Happy to re-add it if we have found this log useful in production.