chore: cleanup tests directory #4742
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanOppenheimer
added
cleanup
alarso16
reviewed
Dec 16, 2025
alarso16
requested changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Removes unused test utilities inherited from geth that were never called in either
corethorsubnet-evm. Cleaning it up also better aligns the tests/ directories between coreth and subnet-evm, which should make future consolidation easier.How this works
Deletes unused files from
graft/coreth/tests/andgraft/subnet-evm/tests/:init.go- only notable change is removedGetRepoRootPathhelper -- test files now useruntime.Caller(0)to locate paths relative to source (is this approach acceptable? -- see comment below)rlp_test_util.go- Legacy geth RLP test utilities, never usedgen_stenv.go,gen_sttransaction.go- Generated code for geth's state test format, never usedHow this was tested
CI
Need to be documented in RELEASES.md?
No