refactor: align PointerTo functions
#4741
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanOppenheimer
added
DO NOT MERGE
JonathanOppenheimer
changed the title
PointerTo functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This PR consolidates pointer creation helpers across the codebase by replacing the type-specific pointer calls such as
utils.NewUint64ornewTrue()with a single genericutils.PointerTo[T any]function. It also makes types more clear when required, or ensures lint will fail on unnecessary type casting.See ava-labs/coreth#1263 (comment) for the original context.
Closes #4567
How this works
utils.PointerTo[T any](x T) *Tto the sharedgraft/evm/utilsmodulePointerTocallsutilstest.PointerToin favor of the utils versionnewTrue()) and replaces withutils.PointerToHow this was tested
CI
Need to be documented in RELEASES.md?
No