build: bundle subnet-evm releasing into releasing workflow #4675

JonathanOppenheimer · 2025-12-10T22:38:10Z

Why this should be merged

This PR does the legwork to ensure that subnet-evm is also built and provided when AvalancheGo is tagged. As planned:

Subnet-EVM releases will be aligned with AvalancheGo releases in the monorepo world

The release version for Subnet-EVM will jump to v1.14.x to properly align

This will reduce complexity regarding having prefixed tagged, or needing to maintain version compatibility separately (Subnet-EVM and AvalancheGo for a given release will always be compatible).

How this works

I just added steps to build the subnet-evm stuff right next to the AvalancheGo steps, largely by copying and pasting / then tweaking the values.

How this was tested

CI

Need to be documented in RELEASES.md?

No

JonathanOppenheimer · 2025-12-10T22:47:48Z

RELEASING_README.md

@@ -0,0 +1,428 @@
+# AvalancheGo Release Guide


This is a combination of the two following old files, edited for clarity, with some monorepo specific details added

https://github.com/ava-labs/avalanchego/blob/dc841a59005ad105808d8ff23a17b96a0f7025bf/graft/coreth/docs/releasing/README.md

https://github.com/ava-labs/avalanchego/blob/dc841a59005ad105808d8ff23a17b96a0f7025bf/graft/subnet-evm/docs/releasing/README.md

I think most of us will struggle to provide substantive review of what is presented here. There is too much content and hard to see what is changing despite the links provided above. I think it would be preferable to ensure a more reviewable structure e.g.

Start with one of the docs that has the meat of the content

Incrementally add content so that reviewers can see what is changing

Iterate until this final form.

Would you like me to do the documentation in a separate PR? Because of the similarity score stuff, the GitHub UI won't show it as a file move in its end state. (does gerrit have a fix for this 😂)

I think another PR makes sense. Maybe rename the file in this PR and then modify it in a follow-on? The main thing to avoid is moving and substantially changing a big file in the same PR.

Gerrit has this issue too, but a gerrit change (PR) targets a single commit that can have multiple versions. Updating a commit involves modifying it and force pushing, each new push creates a new version, and a given review is tied to a specific version.

Ah that's very interesting! tying reviews to versions is quite cool (vs. github it's either out of date or not). Anyway, I've just done the file name change, and will doe the content in a standalone PR.

JonathanOppenheimer · 2025-12-10T22:49:37Z

graft/subnet-evm/Taskfile.yml

  build:
    desc: Compile Subnet EVM binary with git commit and static linking flags
-    cmd: ./scripts/build.sh # ci.yml
+    cmd: ./scripts/build.sh {{.CLI_ARGS}} # ci.yml


is this okay to do in the taskfile?

I don't see why you need this at all

This matches that other scripts do -- the build script accepts an optional custom binary path as an argument, so someone could change the location it's built to.

alarso16

I think this is on the right track (besides all the unrelated changes), but I don't think we need to decide all this before we merge the previous 5 PRs

graft/subnet-evm/scripts/build.sh

alarso16 · 2025-12-11T15:36:18Z

graft/subnet-evm/Taskfile.yml

  build:
    desc: Compile Subnet EVM binary with git commit and static linking flags
-    cmd: ./scripts/build.sh # ci.yml
+    cmd: ./scripts/build.sh {{.CLI_ARGS}} # ci.yml


I don't see why you need this at all

alarso16 · 2025-12-11T15:37:29Z

RELEASING_README.md

+git push origin "$VERSION_RC"
+```
+
+### 6. Test the Release Candidate


A lot of these details are internal to ava labs. Maybe this belongs in the eng-resources repository for testing and deployment

You had requested it be rewritten in #4658. Would you prefer we delete this entirely from AvalancheGo and have the content elsewhere?

alarso16 · 2025-12-11T15:38:07Z

graft/subnet-evm/.github/workflows/bench.yml

This is all out of scope of this PR. Seems more intuitive to me to wait and do a wider cleanup after repos are merged, but file deletions are clear

I don't think it's out of scope -- all the workflow deletions reflect moving code to the top level workflows folder to do a release (but GitHub won't show a move because both, sometimes nearly identical files already exist) Nothing else inside of .github was deleted because that would be out of scope and for another PR.

graft/coreth/.github/workflows/codeql-analysis.yml

…/avalanchego/graft/subnet-evm Rewrites all Go import statements from external package github.com/ava-labs/subnet-evm to internal graft subdirectory github.com/ava-labs/avalanchego/graft/subnet-evm.

…Go tools

JonathanOppenheimer · 2025-12-15T17:08:52Z

graft/subnet-evm/.github/workflows/bench.yml

@@ -1,20 +0,0 @@
-name: Bench


This is just some metrics, and does not need to be a part of AvalancheGo CI imo -- if you want this, you can just run it yourself and see the results.

JonathanOppenheimer · 2025-12-15T17:09:07Z

graft/subnet-evm/.github/workflows/codeql-analysis.yml

@@ -1,72 +0,0 @@
-# For most projects, this workflow file will not need changing; you simply need


This is covered by the root file.

JonathanOppenheimer · 2025-12-15T17:09:19Z

graft/subnet-evm/.github/workflows/notify-metrics-availability.sh

@@ -1,19 +0,0 @@
-#!/usr/bin/env bash


This was seemingly never used, even in subnet-evm. It was only mentioned in tests/fixture/tmpnet/README.md but that's documentation, and the information seemed false.

JonathanOppenheimer · 2025-12-15T17:09:58Z

graft/subnet-evm/.github/workflows/publish_antithesis_images.yml

@@ -1,32 +0,0 @@
-name: Publish Antithesis Images


this has been integrated with avalanchego

JonathanOppenheimer · 2025-12-15T17:11:30Z

graft/subnet-evm/.github/workflows/publish_docker.yml

@@ -1,48 +0,0 @@
-name: Publish Docker Image


this has been integrated with avalanchego

JonathanOppenheimer · 2025-12-15T17:11:39Z

graft/subnet-evm/.github/workflows/release.yml

@@ -1,58 +0,0 @@
-name: Release


no longer necessary

JonathanOppenheimer · 2025-12-15T17:11:53Z

graft/subnet-evm/.goreleaser.yml

@@ -1,45 +0,0 @@
-version: 2


no longer necessary

…eleasing

JonathanOppenheimer · 2025-12-15T17:46:00Z

seem to work!

.github/workflows/build-linux-binaries.yml

.github/workflows/build-tgz-pkg.sh

.github/workflows/trigger-antithesis-subnet-evm.yml

maru-ava · 2025-12-15T19:19:11Z

RELEASING_README.md

@@ -0,0 +1,428 @@
+# AvalancheGo Release Guide


I think most of us will struggle to provide substantive review of what is presented here. There is too much content and hard to see what is changing despite the links provided above. I think it would be preferable to ensure a more reviewable structure e.g.

Start with one of the docs that has the meat of the content

Incrementally add content so that reviewers can see what is changing

Iterate until this final form.

.github/workflows/trigger-antithesis-avalanchego.yml

maru-ava · 2025-12-16T12:56:33Z

RELEASING_README.md

@@ -0,0 +1,428 @@
+# AvalancheGo Release Guide


I think another PR makes sense. Maybe rename the file in this PR and then modify it in a follow-on? The main thing to avoid is moving and substantially changing a big file in the same PR.

Gerrit has this issue too, but a gerrit change (PR) targets a single commit that can have multiple versions. Updating a commit involves modifying it and force pushing, each new push creates a new version, and a given review is tied to a specific version.

graft/subnet-evm/scripts/build.sh

…eleasing

github-project-automation bot added this to avalanchego Dec 10, 2025

JonathanOppenheimer force-pushed the JonathanOppenheimer/migrate-subnet-evm-7-releasing branch 2 times, most recently from 20a052b to baa013a Compare December 10, 2025 22:45

JonathanOppenheimer commented Dec 10, 2025

View reviewed changes

JonathanOppenheimer force-pushed the JonathanOppenheimer/migrate-subnet-evm-7-releasing branch from baa013a to 3691fa9 Compare December 10, 2025 22:52

JonathanOppenheimer self-assigned this Dec 10, 2025

JonathanOppenheimer added evm labels Dec 10, 2025

JonathanOppenheimer linked an issue Dec 10, 2025 that may be closed by this pull request

avalanchego releasing with coreth needs re-documented #4658

Open

JonathanOppenheimer mentioned this pull request Dec 10, 2025

Epic: Migrate subnet-evm repo to grafts/subnet-evm #4645

Open

23 tasks

alarso16 reviewed Dec 11, 2025

View reviewed changes

JonathanOppenheimer force-pushed the JonathanOppenheimer/migrate-subnet-evm-6-lint branch from 301e068 to c594668 Compare December 11, 2025 19:31

JonathanOppenheimer force-pushed the JonathanOppenheimer/migrate-subnet-evm-7-releasing branch from 3691fa9 to 9a28aff Compare December 11, 2025 19:36

JonathanOppenheimer requested a review from alarso16 December 11, 2025 19:41

JonathanOppenheimer force-pushed the JonathanOppenheimer/migrate-subnet-evm-6-lint branch 4 times, most recently from 0f24f7c to 4c33d57 Compare December 11, 2025 23:55

JonathanOppenheimer force-pushed the JonathanOppenheimer/migrate-subnet-evm-7-releasing branch from 54607bc to 3959ec8 Compare December 12, 2025 00:01

JonathanOppenheimer force-pushed the JonathanOppenheimer/migrate-subnet-evm-6-lint branch from 082b7ba to b0f4586 Compare December 12, 2025 00:08

JonathanOppenheimer added 8 commits December 12, 2025 11:42

docs: get further instructions

d9e5893

style: trailing char

cdf86b2

docs: add cd command

f95511f

[migrate-subnet-evm][4] Cleanup go mod configuation and use Avalanche…

8c516b2

…Go tools

style: revert import ordering

d6dda5d

style: revert graft readme changes

37c0c1e

JonathanOppenheimer commented Dec 15, 2025

View reviewed changes

graft/subnet-evm/.github/workflows/release.yml

@@ -1,58 +0,0 @@

name: Release

Copy link

Member Author

JonathanOppenheimer Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no longer necessary

JonathanOppenheimer commented Dec 15, 2025

View reviewed changes

graft/subnet-evm/.goreleaser.yml

@@ -1,45 +0,0 @@

version: 2

Copy link

Member Author

JonathanOppenheimer Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no longer necessary

Merge branch 'master' into JonathanOppenheimer/migrate-subnet-evm-7-r…

22afbeb

…eleasing

JonathanOppenheimer marked this pull request as ready for review December 15, 2025 17:46

JonathanOppenheimer requested a review from a team as a code owner December 15, 2025 17:46

maru-ava reviewed Dec 15, 2025

View reviewed changes

JonathanOppenheimer added evm Related to EVM functionality monorepo subnet-evm Related to the former subnet-evm standalone repository labels Dec 15, 2025

JonathanOppenheimer added 2 commits December 15, 2025 15:17

docs: add scheduling note

b151073

docs: remove needless comments

420149d

JonathanOppenheimer requested a review from maru-ava December 15, 2025 20:22

build: default to /build/

618fa09

maru-ava reviewed Dec 16, 2025

View reviewed changes

style: comment spcae

9efe434

JonathanOppenheimer removed a link to an issue Dec 16, 2025

avalanchego releasing with coreth needs re-documented #4658

Open

JonathanOppenheimer added 3 commits December 16, 2025 12:59

docs: revert new readme for a seperate PR

5bab77b

build: use repo root for build path

cab60a5

Merge branch 'master' into JonathanOppenheimer/migrate-subnet-evm-7-r…

9024db4

…eleasing

JonathanOppenheimer requested review from maru-ava and removed request for joshua-kim and meaghanfitzgerald December 16, 2025 18:03

JonathanOppenheimer changed the title ~~build: bundle subnet-evm releasing into releasing workflow and update releasing docs~~ build: bundle subnet-evm releasing into releasing workflow Dec 16, 2025

maru-ava approved these changes Dec 16, 2025

View reviewed changes

		@@ -1,72 +0,0 @@
		# For most projects, this workflow file will not need changing; you simply need

build: bundle subnet-evm releasing into releasing workflow #4675

Are you sure you want to change the base?

build: bundle subnet-evm releasing into releasing workflow #4675

Conversation

JonathanOppenheimer commented Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why this should be merged

How this works

How this was tested

Need to be documented in RELEASES.md?

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alarso16 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JonathanOppenheimer Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JonathanOppenheimer commented Dec 15, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

JonathanOppenheimer commented Dec 10, 2025 •

edited

Loading

JonathanOppenheimer Dec 15, 2025 •

edited

Loading